Bug 280478 - The „Cap“ and „Miter limit“ properties are not saved in ODG
Summary: The „Cap“ and „Miter limit“ properties are not saved in ODG
Status: RESOLVED FIXED
Alias: None
Product: karbon
Classification: Applications
Component: general (show other bugs)
Version: 2.4-snapshots
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Jan Hambrecht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-20 16:46 UTC by Olaf Schmidt-Wischhöfer
Modified: 2011-08-20 18:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Image file (14.42 KB, application/vnd.oasis.opendocument.graphics)
2011-08-20 16:46 UTC, Olaf Schmidt-Wischhöfer 		Details
Screenshot before saving the image (93.39 KB, image/png)
2011-08-20 16:47 UTC, Olaf Schmidt-Wischhöfer 		Details
Screenshot after loading the saved image file. (93.45 KB, image/png)
2011-08-20 16:47 UTC, Olaf Schmidt-Wischhöfer 		Details
Saving as SVG keeps these proterties, not drops the shadow (5.22 KB, image/svg+xml)
2011-08-20 16:52 UTC, Olaf Schmidt-Wischhöfer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Schmidt-Wischhöfer 2011-08-20 16:46:34 UTC 
Created attachment 63006 [details]
Image file

Version:           2.4-snapshots (using KDE 4.7.0) 
OS:                Linux

Before I saved the attached image file, I changed the „Cap“ and „Miter limit“ settings. When I open the file again, then these values are set to different values.

Reproducible: Didn't try

Steps to Reproduce:
1. Load the attached ODG file
2. Select the shape named „Calligra“.
2. Set the miter limit to 0.
3. Set the cap to „Round Cap“
4. Save the file
5. Close the file.
6. Open the saved file.

Actual Results:  
The miter limit has changed to 2 pt.
The „Cap“ setting has changed to „Square Cap“ 

Expected Results:  
Both settings should be unchanged.

I don't think this is related to the bug, but just in case it helps: The image was originally created in Inkscape and then further edited in Karbon.
Comment 1 Olaf Schmidt-Wischhöfer 2011-08-20 16:47:02 UTC 
Created attachment 63007 [details]
Screenshot before saving the image
Comment 2 Olaf Schmidt-Wischhöfer 2011-08-20 16:47:36 UTC 
Created attachment 63008 [details]
Screenshot after loading the saved image file.
Comment 3 Olaf Schmidt-Wischhöfer 2011-08-20 16:52:55 UTC 
Created attachment 63010 [details]
Saving as SVG keeps these proterties, not drops the shadow
Comment 4 Jan Hambrecht 2011-08-20 18:11:09 UTC 
The miter limit is only relevant when setting the join style to miter. So if you have another join style set like in the attached file, the miter limit is not saved. It would probably a good idea to disable the miter limit edit control when another join style is set.
Comment 5 Jan Hambrecht 2011-08-20 18:35:37 UTC 
Git commit 4683f38e1940d2587288d6f0d111287f3aa4337f by Jan Hambrecht.
Committed on 20/08/2011 at 20:35.
Pushed by jaham into branch 'master'.

disable miter limit edit control if join style is not set to miter join

CCBUG:280478

M  +3    -2    plugins/dockers/strokedocker/StrokeDocker.cpp
M  +1    -1    libs/widgets/KoStrokeConfigWidget.cpp

http://commits.kde.org/calligra/4683f38e1940d2587288d6f0d111287f3aa4337f
Comment 6 Jan Hambrecht 2011-08-20 18:35:37 UTC 
Git commit 6c3d682944c6ade6c1f51c2c29708e28b479a13d by Jan Hambrecht.
Committed on 20/08/2011 at 20:16.
Pushed by jaham into branch 'master'.

Implement loading and saving of linecap attribute from/to odf.

The ODF 1.2 specification seems to finally also specfies a linecap
attribute for stroke styles. So lets support that in Calligra.

BUG:280478

M  +2    -0    libs/flake/KoShape.cpp
M  +24   -1    libs/odf/KoOdfGraphicStyles.cpp

http://commits.kde.org/calligra/6c3d682944c6ade6c1f51c2c29708e28b479a13d