Bug 279663 - Selection Background/Text not drawn as configured in Plastique style
Summary: Selection Background/Text not drawn as configured in Plastique style
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: wallpaper-image (show other bugs)
Version: 4.9.1
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Paolo Capriotti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-08 14:59 UTC by Obi Wan Kenobi
Modified: 2012-09-25 22:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.2
Sentry Crash Report:


Attachments
No text, when thumbnail is selected. (100.31 KB, image/jpeg)
2011-08-08 14:59 UTC, Obi Wan Kenobi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Obi Wan Kenobi 2011-08-08 14:59:08 UTC
Created attachment 62666 [details]
No text, when thumbnail is selected.

Version:           unspecified (using KDE 4.6.2) 
OS:                Linux

When selected Plastique Style for buttons, the name of the wallpaper in the plasma-desktop-settings isn't visible, because the font is white and the beackground is white too. The surrounding of the selected wallpaper is missing.

Reproducible: Always

Steps to Reproduce:
Standard Colours. Select Plastique in the system settings for buttons and controls. Open plasma desktop settings and click on a wallpapaer. 

Actual Results:  
The name and size of the wallpaper isn't visible any more.

Expected Results:  
The thumbnail of the wallpaper and its name and size should have a coloured surrounding, so that the wirting ist readable.
Comment 1 Gregor Tätzner 2011-11-25 18:51:03 UTC
confirmed on KDE 4.7 - is this a Qt or KDE issue?
Comment 2 Frederik Schwarzer 2011-12-03 06:43:51 UTC
Confirmed for 4.8 (around beta 2).

The selection background is not drawn. This issue also affects Dolphin and several other application where selections can be made.

At least the categories "Selection Background", "Selection Text" and "Selection Inactive Text" are not used as configured.

This is clearly not a Plasma issue but a widget style one, so I reassign this to Oxygen. Not because it's their problem, but hoping that they know better where to put it. Sorry if that's a bad idea.
Comment 3 Hugo Pereira Da Costa 2012-06-08 23:26:26 UTC
This is either a kdelibs/kdeui (since it applies only to some widgets  and not others, in several applications) issue or a Qt issue (plastique owns it).
I'll reassign there.
Nothing to do with oxygen
(and in fact, may I suggest that you use oxygen, for which there is no such bug ?)
Also note that the bug is likely fixed in latest dolphin.
Comment 4 Christoph Feck 2012-09-23 17:43:13 UTC
Back to Plasma :) The bug is in the delegate. It incorrectly uses CE_ItemViewItem, instead of PE_PanelItemViewItem to draw the selection background.

https://git.reviewboard.kde.org/r/106544/

(If that gets approved, i will also fix the same issues in kdeplasma-addons)
Comment 5 Christoph Feck 2012-09-25 21:28:05 UTC
Git commit 6003cc29fd5fad92cc43621a6308471db3e505d2 by Christoph Feck.
Committed on 25/09/2012 at 23:24.
Pushed by cfeck into branch 'KDE/4.9'.

Fix wrong selection background rendering
FIXED-IN: 4.9.2
REVIEW: 106544

M  +4    -1    plasma/generic/wallpapers/image/backgrounddelegate.cpp

http://commits.kde.org/kde-workspace/6003cc29fd5fad92cc43621a6308471db3e505d2
Comment 6 Christoph Feck 2012-09-25 22:14:12 UTC
Git commit 0acca71578f7f417238c36e285d92d5d50e6c43e by Christoph Feck.
Committed on 26/09/2012 at 00:10.
Pushed by cfeck into branch 'master'.

Fix wrong selection background rendering

M  +4    -1    wallpapers/pattern/backgrounddelegate.cpp
M  +5    -1    wallpapers/virus/backgrounddelegate.cpp

http://commits.kde.org/kdeplasma-addons/0acca71578f7f417238c36e285d92d5d50e6c43e
Comment 7 Christoph Feck 2012-09-25 22:15:16 UTC
Git commit c9fed42421973aeeef694c3827c1d6e869475663 by Christoph Feck.
Committed on 26/09/2012 at 00:10.
Pushed by cfeck into branch 'KDE/4.9'.

Fix wrong selection background rendering
(cherry picked from commit 0acca71578f7f417238c36e285d92d5d50e6c43e)

M  +4    -1    wallpapers/pattern/backgrounddelegate.cpp
M  +5    -1    wallpapers/virus/backgrounddelegate.cpp

http://commits.kde.org/kdeplasma-addons/c9fed42421973aeeef694c3827c1d6e869475663