Bug 279222 - icon of the progress of the system tray doesn't work
Summary: icon of the progress of the system tray doesn't work
Status: RESOLVED FIXED
Alias: None
Product: kteatime
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Stefan Böhmann
URL:
Keywords:
: 353835 369588 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-08-02 22:50 UTC by kinga.tokarz
Modified: 2020-05-30 20:28 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Running KTeaTime: on the left 4.7.0, on the right 4.6.5 (magnified) (11.83 KB, image/png)
2011-08-07 22:18 UTC, Poborskiii
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kinga.tokarz 2011-08-02 22:50:17 UTC
Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

icon of the progress  of the system tray  is too small and doesn't show flow of time when tea is preparing

Reproducible: Always



Expected Results:  
icon should be visible and show the time to complete the preparation of tea
Comment 1 Poborskiii 2011-08-07 22:18:07 UTC
Created attachment 62647 [details]
Running KTeaTime: on the left 4.7.0, on the right 4.6.5 (magnified)

KTeatime 4.7.0 with little fuzzy blue motionless something vs KTeaTime 4.6.5 with big green/red running indicator
Comment 2 Sergei Andreev 2011-11-05 21:01:05 UTC
*** This bug has been confirmed by popular vote. ***
Comment 3 Mara Raram 2012-01-16 08:41:09 UTC
+1 for the return of the big green/red indicator
Comment 4 Holger Schemel 2013-04-09 12:36:04 UTC
This bug/problem is still present in KDE 4.8.5 (using Kubuntu 12.04.2 LTS).

Is there any hope for a return of the very helpful red/green "alarm clock" indicator in the tray icon of KTeaTime? Was there a technical reason to replace it with that static blue thingy that does not show the progress of the elapsed time anymore (therefore removing quite a good amount of usability of KTeaTIme)? For me, hovering the mouse pointer over the tray icon to see the remaining time in the tool tip that pops up is no real compensation for the missing graphical indicator.

I've already tried to use the old KTeaTime binary of Kubuntu 11.04, but unfortunately (and as suspected) there are missing library dependencies.
Comment 5 Stefan Böhmann 2013-04-09 16:56:09 UTC
This bug/regression ist still present in current KDE versions (4.10 and dev).

The reason to replace it was the port to the new KDE system tray (libknotificationitem) and that this new implementation didn't provide a easy, practicable way to update the tray icon every few seconds (milliseconds).

Meanwhile, there could be this functionality in libknotificationitem. Regardless, I also have an idea how to get it implemented reasonable.

I will implement it and therefore I added it to the list of planned features [1] for the SC 4.11 release.


[1] http://techbase.kde.org/Schedules/KDE4/4.11_Feature_Plan#kdetoys
Comment 6 Adam Porter 2013-05-07 19:16:46 UTC
Was it absolutely necessary to port it to libknotificationitem before it had feature parity?
Comment 7 Christoph Feck 2013-05-14 21:17:49 UTC
No. But old-style system tray icons had their own share of bugs, to the point that the icon could go completely invisible.
Comment 8 Tomasz C. 2013-06-07 00:07:42 UTC
Is a new version is available for download from the git repository to test it?
Comment 9 Christoph Feck 2013-06-14 00:26:38 UTC
Tomasz, there is no new version yet.
Comment 10 Tomasz C. 2014-02-19 00:57:22 UTC
Stefan, in 4.13?
Comment 11 kinga.tokarz 2014-04-26 22:06:11 UTC
Is it possible that the problem will be repaired third anniversary of the notification?
Comment 12 Andrius Štikonas 2014-11-21 17:23:34 UTC
(In reply to kinga.tokarz from comment #11)
> Is it possible that the problem will be repaired third anniversary of the
> notification?

Unfortunately it is still present even after the port to KF5.
Comment 13 Andrius Štikonas 2015-12-05 16:57:17 UTC
*** Bug 353835 has been marked as a duplicate of this bug. ***
Comment 14 Martin Sandsmark 2016-07-05 17:33:39 UTC
https://git.reviewboard.kde.org/r/128379/ just fixes the overlay icon

https://git.reviewboard.kde.org/r/128380/ brings back the progress indicator as well
Comment 15 Martin Sandsmark 2016-07-05 19:23:32 UTC
Git commit 0c39c4a5d6a3cb362cb5d110150ddb885a9f43ed by Martin T. H. Sandsmark.
Committed on 05/07/2016 at 19:22.
Pushed by sandsmark into branch 'master'.

Fix overlay icon.

For some reason KSNI doesn't show the overlay icon unless we send the
normal icon as a pixmap.

REVIEW: 128379

M  +1    -1    src/toplevel.cpp

http://commits.kde.org/kteatime/0c39c4a5d6a3cb362cb5d110150ddb885a9f43ed
Comment 16 Martin Sandsmark 2016-08-06 10:47:24 UTC
Git commit 12368fd24be1a16e9f388bca131a7e9a23cb9eb3 by Martin T. H. Sandsmark.
Committed on 06/08/2016 at 10:46.
Pushed by sandsmark into branch 'master'.

Reimplement support for progress indicator

Since we don't use setIconByName() anymore we can't get the icon name
elsewhere, so we store it ourselves.

REVIEW: 128380

M  +32   -10   src/toplevel.cpp
M  +1    -0    src/toplevel.h

http://commits.kde.org/kteatime/12368fd24be1a16e9f388bca131a7e9a23cb9eb3
Comment 17 Tomasz C. 2016-09-16 18:56:25 UTC
A progress bar still does not work in version 16.08.1
Systray icon was restored with kde4 and did not fit the Plasma 5.

I think it's better to undo the change and let it be a nice icon that corresponds to the Plasma 5, although it will not be a progress bar.
Comment 18 Andrius Štikonas 2016-10-16 13:56:41 UTC
Tomasz, I don't think kteatime is that well maintained, so you should probably try to do the change yourself otherwise nobody will do it...
Comment 19 Andrius Štikonas 2016-10-16 13:57:01 UTC
*** Bug 369588 has been marked as a duplicate of this bug. ***
Comment 20 Martin Sandsmark 2020-05-30 20:28:52 UTC
> A progress bar still does not work in version 16.08.1

Because the patch wasn't included in 16.08.1...

Closing again.