Bug 278568 - Internal source combo box is not updated when adding a new table to the project
Summary: Internal source combo box is not updated when adding a new table to the project
Status: CLOSED FIXED
Alias: None
Product: KEXI
Classification: Applications
Component: Reports and Printouts (show other bugs)
Version: 2.4 alpha3 (Calligra 2.4 alpha3)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Adam Pigg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 18:36 UTC by Dimitrios T Tanis
Modified: 2012-08-11 11:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitrios T Tanis 2011-07-26 18:36:05 UTC
Version:           2.4 alpha3 (Calligra 2.4 alpha3) (using KDE 4.6.0) 
OS:                Linux

When adding a new table to the project, you cannot see that table in the report's internal source combo, until you restart Kexi.

Reproducible: Always

Steps to Reproduce:
Add a new table > Open report designer > click Data source tab > Click internal source combo.

Actual Results:  
The newly added table is not displayed in the combo values.

Expected Results:  
Internal source combo should be updated, at least when loading a new object in memory (that is either creating a new report OR opening an existing report in Design view)

The best way of course would be to propagate changes to the tables collection to all the relevant widgets (this for the distant future), so that they can be updated without needing to reload the objects containing them.
Comment 1 Dimitrios T Tanis 2011-07-26 18:39:33 UTC
Additional Info:
1) The sorting of the tables is also different from what they are displayed in Project Navigator.
2) There are two empty rows in the combo box value (the first and last).
Comment 2 Adam Pigg 2011-08-17 21:23:45 UTC
Git commit 0a194c446f6a8768c2c2d90914b7be04deb5ef26 by Adam Pigg.
Committed on 17/08/2011 at 23:19.
Pushed by piggz into branch 'master'.

Seperated out the internal source combo box to allow overriding of the mousePressEvent so that the list of tables can be requeried.
BUG:278568

M  +3    -28   kexi/plugins/reports/kexisourceselector.cpp
M  +1    -1    kexi/plugins/reports/kexisourceselector.h
A  +63   -0    kexi/plugins/reports/InternalSourceSelector.cpp     [License: LGPL (v2.1+)]
A  +44   -0    kexi/plugins/reports/InternalSourceSelector.h     [License: LGPL (v2.1+)]
M  +2    -1    kexi/plugins/reports/CMakeLists.txt

http://commits.kde.org/calligra/0a194c446f6a8768c2c2d90914b7be04deb5ef26