Bug 278375 - Incorrect NASM highlighting on Kate 3.6.2
Summary: Incorrect NASM highlighting on Kate 3.6.2
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: syntax (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-24 08:35 UTC by Lyle Putnam
Modified: 2011-07-25 13:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fixes the problem. (1.52 KB, patch)
2011-07-24 08:35 UTC, Lyle Putnam
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lyle Putnam 2011-07-24 08:35:17 UTC
Created attachment 62131 [details]
Fixes the problem.

Version:           unspecified (using KDE 4.6.2) 
OS:                Linux

The regular expression to detect suffixed hexadecimal numbers was wrong and including registers ah, bh, ch, dh.

Reproducible: Always

Steps to Reproduce:
Set highlighting to Assembler -> Intel x86 (NASM);
Enter ah, bh, ch, or dh.

Actual Results:  
The register name is highlighted as a number, not a register.

Expected Results:  
It should be highlighted as a register.
Comment 1 Erlend Hamberg 2011-07-25 13:30:29 UTC
Git commit a191de4ed747f1f766098fc37c7a21ab333835a9 by Erlend Hamberg.
Committed on 25/07/2011 at 15:28.
Pushed by ehamberg into branch 'master'.

correctly highlight register names

The regular expression to detect suffixed hexadecimal numbers was wrong
and including registers ah, bh, ch, dh.

Thanks to Lyle Putnam for the patch.

BUG: 278375

M  +6    -1    part/syntax/data/nasm.xml

http://commits.kde.org/kate/a191de4ed747f1f766098fc37c7a21ab333835a9