Bug 277200 - Krita do not save the 'visible' or 'hidden' status of layer inside *.ora xml stack
Summary: Krita do not save the 'visible' or 'hidden' status of layer inside *.ora xml ...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 13:59 UTC by David REVOY
Modified: 2011-07-07 11:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2011-07-06 13:59:20 UTC
Version:           svn trunk
OS:                Linux

Krita do not save the 'visible' or 'hidden' status of layer inside *.ora xml stack , so always save all layer visible , always open all ora layer visible. 

*exemple of markup* 
by Mypaint and Gimp (ora plugin) :
visibility="visible"
visibility="hidden"

*exemple in a xml stack*
by Mypaint and Gimp (ora plugin) :
<?xml version='1.0' encoding='UTF-8'?>
<image h="1536" w="2240">
  <stack>
    <layer mypaint_strokemap_v2="data/layer000_strokemap.dat" name="shouldbehidden" opacity="1.0" src="data/layer000.png" visibility="hidden" x="1216" y="896" />
    <layer mypaint_strokemap_v2="data/layer001_strokemap.dat" name="shouldbevisible" opacity="1.0" src="data/layer001.png" visibility="visible" x="1280" y="320" />
    <layer mypaint_strokemap_v2="data/layer002_strokemap.dat" name="shouldbehidden" opacity="1.0" src="data/layer002.png" visibility="hidden" x="448" y="704" />
    <layer mypaint_strokemap_v2="data/layer003_strokemap.dat" name="shouldbevisible" opacity="1.0" src="data/layer003.png" visibility="visible" x="0" y="0" />
    <layer background_tile="data/background_tile.png" name="background" opacity="1.0" src="data/background.png" visibility="visible" x="0" y="0" />
  </stack>
</image>


*Test file :*
This ora file contain 4 layer ( eyes close for hidden , eye open for visible ). 
So it's a firendly ora to make test for the developper who will fix it. 
http://david.revoy.free.fr/forums/krita/2011-07-06_visible-hidden-test.ora


Reproducible: Always

Steps to Reproduce:
Open this ora file with hidden layer : http://david.revoy.free.fr/forums/krita/2011-07-06_visible-hidden-test.ora

Actual Results:  
always open/save all *.ora layer as visible ( no status )

Expected Results:  
makes *.ora open/save hidden and visible layer status
Comment 1 Sven Langkamp 2011-07-07 10:33:31 UTC
Git commit 61125872015f4654a6605600bc4725bfd4b8ac45 by Sven Langkamp.
Committed on 07/07/2011 at 02:44.
Pushed by langkamp into branch 'master'.

load and save layer visibility in openraster
BUG:277200

M  +5    -0    krita/ui/openrastertk/kis_open_raster_stack_load_visitor.cpp     
M  +1    -0    krita/ui/openrastertk/kis_open_raster_stack_save_visitor.cpp     

http://commits.kde.org/calligra/61125872015f4654a6605600bc4725bfd4b8ac45
Comment 2 David REVOY 2011-07-07 11:16:46 UTC
Thanks Sven , it works and that was very speed-of-light fixing. It helps here a lot as I work most of the time with *.ora to switch apps since few weeks. Thanks !