Bug 275502 - Sort WiFi networks
Summary: Sort WiFi networks
Status: RESOLVED FIXED
Alias: None
Product: solid
Classification: Frameworks and Libraries
Component: networkmanagement (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Will Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 00:48 UTC by Kai Uwe Broulik
Modified: 2011-09-01 17:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: nm09


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2011-06-13 00:48:51 UTC
Version:           unspecified (using Devel) 
OS:                Linux

I can see no pattern in the found WiFi list.
Either sort them by strength or by encryption or by name but please sort them somehow.

Reproducible: Sometimes
Comment 1 Lamarque V. Souza 2011-06-13 06:56:53 UTC
The list is not sorted at all, entries are just appended and the outdated ones removed. Actually it is a QHash, if you know how hashes work you know they are difficult to sort efficiently. The fact that the sort involves several criteria (one for each item type) is a complication to make the sorting efficient. I have been thinking on how to do it and even if I find a efficient solution that would require refactoring some classes, which will take time.
Comment 2 Lamarque V. Souza 2011-08-30 18:17:45 UTC
Git commit 0e12e39224f3f4011a0e3d04760a07ef6461cf8c by Lamarque V. Souza.
Committed on 30/08/2011 at 20:10.
Pushed by lvsouza into branch 'nm09'.

Sort connection list by type and then by activation state (activated,
activating, unknown).
Default type order is: wifi, hidden wifi, VPN, Gsm, other
connection types (ethernet, dsl, cdma, etc), unconfigured access points
(wifi), unconfigured interface. This order is hard-coded.

BUG: 275502
FIXED-IN: nm09

M  +20   -5    applet/activatablelistwidget.cpp
M  +19   -1    libs/client/remoteactivatablelist.cpp
M  +1    -1    plasma_nm_version.h
M  +9    -5    libs/internals/activatable.h
M  +1    -1    applet/activatablelistwidget.h

http://commits.kde.org/networkmanagement/0e12e39224f3f4011a0e3d04760a07ef6461cf8c
Comment 3 Kai Uwe Broulik 2011-09-01 14:17:35 UTC
Are they now alphabetically sorted as well (which actualy was my initial request) or is this still not possible do to your QHash stuff?
Comment 4 Lamarque V. Souza 2011-09-01 17:32:38 UTC
Git commit 2144cb1b554d6b3e9b9e7fb54bcf579d2336524d by Lamarque V. Souza.
Committed on 01/09/2011 at 19:31.
Pushed by lvsouza into branch 'nm09'.

Also sort connections by name (or ssid if applicable).

CCBUG: 275502

M  +12   -1    libs/client/remoteactivatablelist.cpp

http://commits.kde.org/networkmanagement/2144cb1b554d6b3e9b9e7fb54bcf579d2336524d