Bug 275031 - Cell references are not converted from MS format to OpenFormula format when loading MS Excel created odf files
Summary: Cell references are not converted from MS format to OpenFormula format when l...
Status: VERIFIED FIXED
Alias: None
Product: calligrasheets
Classification: Applications
Component: opendocument (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Calligra Sheets (KSpread) Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 08:57 UTC by swathi
Modified: 2011-08-23 11:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description swathi 2011-06-06 08:57:51 UTC 
Version: git checkout 09bf66c4b404f9fb8d3c2912ea77d02646e38f0a
        (Using KDE 4.5.5)                
     OS: Kubuntu 10.10
Test data is in ODS format which has some conditional formatting in it.
Open the same document in Calligra Tables, check the display of the results.

Expected outcome:
Results should be displayed properly.
Actual outcome:
PARSE error is displaying on the place of results.

Frequency:
Always.
Comment 1 Marijn Kruisselbrink 2011-07-13 10:10:57 UTC 
Test data is missing, without test data it is impossible to fix.
Comment 2 Marijn Kruisselbrink 2011-07-27 14:33:26 UTC 
Okay, can confirm the bug, loading formulas from ms excel saved odf files should go through the same conversion code as when ooxml files are loaded.
Comment 3 Marijn Kruisselbrink 2011-08-17 08:43:40 UTC 
Git commit ef7c0d057c1c2132df28423aa58689549f46d39d by Marijn Kruisselbrink.
Committed on 17/08/2011 at 10:42.
Pushed by mkruisselbrink into branch 'master'.

move MSOOXML formula conversion to tables itself, as it is also needed when loading ms office created odf files.
BUG: 275031

M  +2    -1    filters/tables/xlsx/TestFormulaParser.cpp
M  +1    -1    filters/tables/xlsx/XlsxXmlWorksheetReader.cpp
M  +0    -1    tables/CMakeLists.txt
M  +51   -1    tables/Util.cpp
M  +0    -45   filters/tables/xlsx/FormulaParser.cpp
M  +0    -5    filters/tables/xlsx/FormulaParser.h
M  +8    -0    tables/Util.h

http://commits.kde.org/calligra/ef7c0d057c1c2132df28423aa58689549f46d39d
Comment 4 swathi 2011-08-23 11:21:25 UTC 
Verified in bf7bf12d4548e039e80e0dc863d3f4039745f8bd.