Bug 274505 - id3v2 TAG frame parsing stops when a zero size frame is analyzed.
Summary: id3v2 TAG frame parsing stops when a zero size frame is analyzed.
Status: RESOLVED WORKSFORME
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 1.7
Platform: Compiled Sources Other
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-30 11:38 UTC by Giuseppe Meloni
Modified: 2022-11-18 05:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Simple workaround patch (1.39 KB, patch)
2011-10-03 22:04 UTC, llev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Giuseppe Meloni 2011-05-30 11:38:43 UTC
Version:           1.7 (using KDE 4.6.3) 
OS:                other

Some files have one or more id3v2 frames with zero size. A lot of them are WMA converted to MP3 and have several WM/Private tag with zero size.
Also, sometimes the tags WOAF, WOAR and WOAS have the size = 0.
So the check in the following code stops the parsing end all tags after the 0 size frame are skipped (ie APIC tag).
// Checks to make sure that frame parsed correctly.
if(frame->size() <= 0) {
  delete frame;
  return;
}

Probably my test files are not fully compliant with the id3v2 specification, but there is a way to solve this problem? At the moment I've just comment out the frame size check.

Reproducible: Always

Steps to Reproduce:
Try to parse the attached file
Taglibe doesn't retrieve the cover art, while almost all tag editor yes.

Actual Results:  
No Cover is retrieved.

Expected Results:  
Taglib should "see" the cover art inside the file.
Comment 1 Giuseppe Meloni 2011-05-30 12:24:34 UTC
Here finde an example file: http://cting.org/~peps/example.mp3
Comment 2 llev 2011-10-03 22:04:22 UTC
Created attachment 64182 [details]
Simple workaround patch

It's definitely terrible issue from my point of view.
I faced with zero-sized MCDI frame.
I have to use attached patch as workaround fir the problem with zero-sized frames.
Comment 3 llev 2011-10-03 22:15:34 UTC
Here's zero-sized MCDI frame: http://shareflare.net/download/14096.1cbb6b66744b25cb397b1cbfbaa2/I_Luv_It.mp3.html
Comment 4 Justin Zobel 2022-10-19 22:11:06 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 5 Bug Janitor Service 2022-11-03 05:06:20 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2022-11-18 05:16:36 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!