Bug 273862 - Not all filters have a "Preview" checkbox
Summary: Not all filters have a "Preview" checkbox
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-22 17:46 UTC by pentalis
Modified: 2011-06-15 22:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pentalis 2011-05-22 17:46:19 UTC
<copypaste title here>
Comment 1 Sven Langkamp 2011-06-15 03:39:52 UTC
What does this mean? I don't see any preview checkbox.
Comment 2 pentalis 2011-06-15 03:54:50 UTC
Now that I check the filters, I see none of them have a "preview" checkbox, so my interpretation of the original wish is as follows:

Make filters have a checkbox that lets you set whether or not to have a preview of the filter if it were applied.
Comment 3 Halla Rempt 2011-06-15 08:53:34 UTC
Color adjustment actually still has a vestigial preview checkbox...
Comment 4 Halla Rempt 2011-06-15 08:57:54 UTC
Actually, the color adjustment filter still has a preview checkbox. Let's check the others. Hm... We have crash when clicking on autocontrast. All edge detection filters are broken. All emboss filters are broken, except variable depth. Sharpen crashes. Phong bumpmap crashes...
Comment 5 Sven Langkamp 2011-06-15 22:27:11 UTC
Git commit b1430f9e27c1e0a12145e63b21c11b283b76f84c by Sven Langkamp.
Committed on 15/06/2011 at 22:23.
Pushed by langkamp into branch 'master'.

add preview checkbox to filters, temporary mask ins't hidden yet
CCBUG:273862

M  +20   -2    krita/ui/dialogs/kis_dlg_filter.cpp     
M  +2    -0    krita/ui/dialogs/kis_dlg_filter.h     
M  +14   -7    krita/ui/forms/wdgfilterdialog.ui     

http://commits.kde.org/calligra/b1430f9e27c1e0a12145e63b21c11b283b76f84c
Comment 6 Sven Langkamp 2011-06-15 22:49:04 UTC
Git commit cb67e94fd16a0e51023398db6943f9b4626e2298 by Sven Langkamp.
Committed on 15/06/2011 at 22:48.
Pushed by langkamp into branch 'master'.

hide preview effect mask when preview is disabled
BUG:273862

M  +2    -2    krita/image/kis_layer.cc     

http://commits.kde.org/calligra/cb67e94fd16a0e51023398db6943f9b4626e2298