Version: unspecified (using KDE 4.6.1) OS: Linux The user interface for the shutdown feature appears very confusing: Last time I used ktorrent I assumed the prominent "Shutdown" button in the toolbar was used to cleanly shutdown all network connections before quitting the program. When I clicked it and (seemingly) nothing happened I left the program with File/Quit and forgot about it. Some day later I downloaded another torrent, and when the download was complete the PC started shutting down out of nowhere. I'm not entirely sure how to improve the interface. Just some thoughts: - There should be a noticeable feedback when clicking the button. There will be a thin frame indicating that the option is active, but it's practically invisible because the widget is focused when clicked (might be a theme problem). A checkbox would be more recognizable. - The label "Shutdown" is ambiguous. Unfortunately "Shutdown system after transfer" is way to long for the toolbar. - The option could be removed from the toolbar and moved into the "Configure Shutdown" dialog, but that way there would be no indication in the main window that the PC is going to be shut down after the last transfer. Reproducible: Always
> The user interface for the shutdown feature appears very confusing: Last time > I used ktorrent I assumed the prominent "Shutdown" button in the toolbar was > used to cleanly shutdown all network connections before quitting the program. Whatever gave you that idea ? > - There should be a noticeable feedback when clicking the button. There will > be a thin frame indicating that the option is active, but it's practically > invisible because the widget is focused when clicked (might be a theme > problem). A checkbox would be more recognizable. KTorrent has no influence on how toggle buttons are rendered, if it is not obvious, then I can only recommend, you use a different style. > - The label "Shutdown" is ambiguous. Unfortunately "Shutdown system after > transfer" is way to long for the toolbar. The best I can give, is an improved tooltip. And if no shutdown rules are set, then popup the config dialog. That would at least make things clear, for people using the plugin the first time.
(In reply to comment #1) > Whatever gave you that idea ? It seemed like the most obvious explanation. I wanted to leave the program and there was a big red Shutdown button, so I figured it was a way to gracefully quit the program (i.e. disconnect from all peers, then exit). I believe I've seen similar functions in other torrent clients. A function to halt the entire system is not something you'd expect in a normal user application, although it makes sense in this case. > The best I can give, is an improved tooltip. And if no shutdown rules are set, > then popup the config dialog. That would at least make things clear, for people > using the plugin the first time. That would be a huge improvement. Opening the config dialog the first time the button is clicked would make it obvious what the function is meant to do. I'd probably prefer a "Shutdown system after last transfer" checkbox below the torrent list, but I don't know if a plugin can do that. Regards, Ingo
Git commit b6e0ba1694b15df550cb49121de4befee1b8ac17 by Joris Guisson. Committed on 23/04/2011 at 18:58. Pushed by guisson into branch 'master'. Shutdown plugin revamp: - Show shutdown plugin's config dialog when no rules are present and the enable button is pressed - Improve tooltip of shutdown plugin enable action - Make it possible to wait for several events before activating the shutdown action BUG: 271311 M +2 -0 ChangeLog M +5 -0 plugins/shutdown/shutdowndlg.cpp M +31 -20 plugins/shutdown/shutdowndlg.ui M +12 -1 plugins/shutdown/shutdownplugin.cpp M +110 -38 plugins/shutdown/shutdownruleset.cpp M +16 -0 plugins/shutdown/shutdownruleset.h http://commits.kde.org/ktorrent/b6e0ba1694b15df550cb49121de4befee1b8ac17