Bug 270217 - Precondition-objects in sequence diagrams are saved on wrong position
Summary: Precondition-objects in sequence diagrams are saved on wrong position
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 13:27 UTC by Alexander Bauer
Modified: 2014-02-15 09:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Bauer 2011-04-06 13:27:15 UTC
Version:           unspecified (using KDE 4.4.4) 
OS:                Linux

I placed precondition-objects to an object in a sequence diagram and moved them to the correct position on the lifetime line of the object. Finally I saved the document. When I reopened the document, all precondition-objects were placed on the same position. One object was placed over the other object. I placed them again to the correct position and also saved the document again. After reopening the file, I had the same again. I already tried to delete, save, reopen, place again, save, reopen...same thing. Saving the document to a new file (save as...) also doesn't work. Marking everything, copy and paste to a new diagram...you may try on your own what happens then. Small hint, the result is not what you have copied.

Reproducible: Couldn't Reproduce




OS: Linux (i686) release 2.6.34.7-0.7-desktop
Compiler: gcc
Comment 1 Joris Steyn 2014-02-15 09:29:26 UTC
This bug report describes two issues:

A. Precondition objects loose their position on the lifeline
B. Precondition objects do net get pasted when pasting a diagram

The first issue seems not to exist in recent versions of Umbrello, the second issue will be fixed in Umbrello 4.13.
Comment 2 Joris Steyn 2014-02-15 09:34:11 UTC
Git commit 88954fdc2f0233edc1a6209e56dc479d90f182f0 by Joris Steyn.
Committed on 11/02/2014 at 21:00.
Pushed by jorissteyn into branch 'master'.

Fix issues with sequence diagram UR and clipboard

This was regression introduced in the recent UR changes (c4e71ef).

Summary of fixed issues:
 * crash when pasting sequence diagram
 * crash and other misbehaviour on UR message/object widget actions
 * pasted widgets were added to the document twice (duplicate widget elements
   in saved XMI) - happened with all diagram types
 * extra: undo removing an object widget did not restore the connected messages
 * precondition widgets were never included when pasting a sequence diagram

M  +0    -9    umbrello/clipboard/umlclipboard.cpp
M  +51   -8    umbrello/clipboard/umldragdata.cpp
M  +5    -2    umbrello/clipboard/umldragdata.h
M  +19   -0    umbrello/cmds/widget/cmd_baseWidgetCommand.cpp
M  +1    -0    umbrello/cmds/widget/cmd_baseWidgetCommand.h
M  +3    -4    umbrello/cmds/widget/cmd_createWidget.cpp
M  +1    -3    umbrello/cmds/widget/cmd_removeWidget.cpp
M  +2    -8    umbrello/umlscene.cpp
M  +11   -1    umbrello/widgets/messagewidget.cpp
M  +1    -0    umbrello/widgets/messagewidget.h
M  +34   -8    umbrello/widgets/preconditionwidget.cpp
M  +6    -0    umbrello/widgets/preconditionwidget.h
M  +0    -1    umbrello/widgets/widget_factory.cpp

http://commits.kde.org/umbrello/88954fdc2f0233edc1a6209e56dc479d90f182f0