Bug 270122 - Kate incorrectly saves configuration to disk when configDialog() is invoked
Summary: Kate incorrectly saves configuration to disk when configDialog() is invoked
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: application (show other bugs)
Version: SVN
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 02:46 UTC by Spencer Jackson
Modified: 2011-11-07 12:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Spencer Jackson 2011-04-05 02:46:02 UTC 
Version:           SVN (using KDE 4.6.1) 
OS:                Linux

Kate includes a reference to writeConfig() at the end of configDialog(). However, the documentation states, "changes will be applied to the editor, but not saved anywhere automagically, call writeConfig() to save them," implying that this behaviour is incorrect.

Reproducible: Always

Steps to Reproduce:
Invoke writeConfig()

Actual Results:  
Settings were written to disk.

Expected Results:  
No settings should be written to disk.
Comment 1 Milian Wolff 2011-04-05 11:35:55 UTC 
you mean "steps to reproduce: invoke configDialog()" probably, right? ;-)

patches welcome but make sure kate, kwrite and kdevelop still work as expected.
Comment 2 Dominik Haumann 2011-08-13 19:23:15 UTC 
Does that lead to any misbehavior?
Review request: https://git.reviewboard.kde.org/r/101026
Comment 3 Christoph Cullmann 2011-11-07 12:13:49 UTC 
Git commit 8638e9a2ce9f65316df992cf7a39ca8294c9e77b by Christoph Cullmann.
Committed on 07/11/2011 at 13:13.
Pushed by cullmann into branch 'master'.

fix KTextEditor::Editor::configDialog implementation to not save config
this was not correct, as stated in docs otherwise
BUG: 270122

M  +0    -2    part/utils/kateglobal.cpp

http://commits.kde.org/kate/8638e9a2ce9f65316df992cf7a39ca8294c9e77b