Bug 269958 - Some entries have wrong background in GIMP tool window
Summary: Some entries have wrong background in GIMP tool window
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-02 19:53 UTC by Ruslan Kabatsayev
Modified: 2011-04-03 12:27 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Kabatsayev 2011-04-02 19:53:31 UTC 
Version:           unspecified
OS:                Linux

See: http://simplest-image-hosting.net/png-0-shot-042

Reproducible: Didn't try




ebac21313573e8f08d5200c4e0fd9c2800b139dc is the first bad commit
commit ebac21313573e8f08d5200c4e0fd9c2800b139dc
Author: Hugo Pereira Da Costa <hugo@oxygen-icons.org>
Date:   Mon Mar 28 17:35:51 2011 +0200

    attempt at properly rendering groupbox background.

:040000 040000 05c17efcef498941eef53c0ae9b902f7d32ac39a 11a017c7d832f6f25dc7432be71efaba321ccb77 M      src
Comment 1 Hugo Pereira Da Costa 2011-04-03 02:02:39 UTC 

*** This bug has been marked as a duplicate of bug 269956 ***
Comment 2 Hugo Pereira Da Costa 2011-04-03 02:18:43 UTC 
ok re-oppening because even if the other bug is fixed, background rendering issues still remain in gimp->preferences.
The problem is the same: false positive when identifying groupboxes.
I have ideas to fix, though.
Comment 3 Hugo Pereira Da Costa 2011-04-03 11:23:05 UTC 
Git commit c33e202872c4e1072aa5056d7c6c2e60ae8cd537 by Hugo Pereira Da Costa.
Committed on 03/04/2011 at 11:26.
Pushed by hpereiradacosta into branch 'master'.

register groupboxes into engine at first call to renderGroupBoxBackground.
This fixes false positive to groupboxbackground rendering.
CCBUG: 269958

M  +1    -0    src/animations/oxygenanimations.cpp     
M  +8    -0    src/animations/oxygenanimations.h     
A  +69   -0    src/animations/oxygengroupboxengine.h         [License: LGPL (v2)]
M  +6    -1    src/oxygenstyle.cpp     

http://commits.kde.org/oxygen-gtk/c33e202872c4e1072aa5056d7c6c2e60ae8cd537
Comment 4 Hugo Pereira Da Costa 2011-04-03 11:23:52 UTC 
that closes it for good.