Bug 268895 - Creating a new file uses .desktop template title and just removes the “...”
Summary: Creating a new file uses .desktop template title and just removes the “...”
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-19 13:49 UTC by Kai Uwe Broulik
Modified: 2011-03-20 13:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2011-03-19 13:49:48 UTC
Version:           unspecified (using KDE 4.6.1) 
OS:                Linux

The files in the Create New menu (of which almost no application besides OpenOffice take advantage of) are template .desktop files. They contain a Title tag indicating the MENU ENTRY. So, it is “Text file...” and when clicking the particular empty, a window (using another entry from the .desktop file) prompts you. The file name entered by default is the Title entry without the “...”.
The problem here is, in the German localization we have a space befor the ellipsis, resulting in the entry being “Textdatei …” and the new file being name “Textdatei ” with a space at the end.
The routing should also trim unneccessary spaces.

Reproducible: Always
Comment 1 Frank Reininghaus 2011-03-19 15:16:35 UTC
Thanks for the bug report! In principle, this would be easy to fix in KNewFileMenu. However, I wonder if the space before "..." in German and two other localizations (hsb, sl) is intentional. If this is not the case, the better solution would be to remove the spaces in the .desktop files.

Kai, Peter: Do you happen to know if that space is really supposed to be there in the German (and the other two) localizations? If you don't know, we could try to contact the localization teams.
Comment 2 Kai Uwe Broulik 2011-03-19 15:38:39 UTC
I am in the German i18n team, I just forwarded this bug and your comment to the mailing list :)
Comment 3 Kai Uwe Broulik 2011-03-19 20:57:47 UTC
Independantly from the team's decision I looked up the grammar/typography rule and in German we definitly have a space before the ellipsis, so this may not be changed.
Comment 4 Frederik Schwarzer 2011-03-20 02:30:27 UTC
Yep, definitely intentional in German.
Comment 5 Frank Reininghaus 2011-03-20 13:13:18 UTC
Git commit 04b6451e6449c706d5b4d1265e4ac172e3de07b8 by Frank Reininghaus.
Committed on 20/03/2011 at 13:10.
Pushed by freininghaus into branch 'KDE/4.6'.

KNewFileMenu: remove spaces at the end of the default file name

In some languages, there is a space between the file type and "..." in
the menu entry of the "Create New" menu. This space should be removed
from the menu entry text in order to get the default file name.

BUG: 268895
FIXED-IN: 4.6.2

M  +2    -0    kfile/knewfilemenu.cpp     

http://commits.kde.org/kdelibs/04b6451e6449c706d5b4d1265e4ac172e3de07b8
Comment 6 Frank Reininghaus 2011-03-20 13:16:06 UTC
Git commit 95a0167a2ebd9a78808c57a70de790dc91d1823b by Frank Reininghaus.
Committed on 20/03/2011 at 13:10.
Pushed by freininghaus into branch 'master'.

KNewFileMenu: remove spaces at the end of the default file name

In some languages, there is a space between the file type and "..." in
the menu entry of the "Create New" menu. This space should be removed
from the menu entry text in order to get the default file name.

CCBUG: 268895
(cherry picked from commit 04b6451e6449c706d5b4d1265e4ac172e3de07b8)

M  +2    -0    kfile/knewfilemenu.cpp     

http://commits.kde.org/kdelibs/95a0167a2ebd9a78808c57a70de790dc91d1823b