Bug 267880 - Please update Finnish holidays
Summary: Please update Finnish holidays
Status: RESOLVED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kholidays (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR wishlist
Target Milestone: ---
Assignee: David E. Narvaez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 15:55 UTC by Lasse Liehu
Modified: 2012-11-29 02:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.4


Attachments
Updated holiday_fi_fi (3.08 KB, text/plain)
2011-03-07 15:55 UTC, Lasse Liehu
Details
Updated holiday_fi_fi with comments (4.28 KB, application/octet-stream)
2011-04-15 18:32 UTC, Lasse Liehu
Details
Fixed holiday_fi_fi (5.88 KB, application/octet-stream)
2011-10-18 23:26 UTC, Lasse Liehu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lasse Liehu 2011-03-07 15:55:58 UTC
Created attachment 57745 [details]
Updated holiday_fi_fi

Version:           unspecified
OS:                Linux

I've updated the Finnish holidays file (kdepimlibs/kholidays/holidays/plan2/holiday_fi_fi). I've also contacted the original author and the source and both are okay.

I've basically:
* corrected a few of them ("Laskiaistiistai", Karkauspäivä/Leap Day)
* tried to categorize them a bit (couldn't do better)
* added some missing days, mostly flag or otherwise notable days

Reproducible: Didn't try
Comment 1 John Layt 2011-04-15 12:09:49 UTC
Hi Lasse, thanks for the update.  Could I just ask if you can provide informal English translations of the holiday names as inline comments?  It would make my job easier when I make file format changes in the future.  Thanks!
Comment 2 Lasse Liehu 2011-04-15 18:32:04 UTC
Created attachment 59017 [details]
Updated holiday_fi_fi with comments

Sure. I got the "translations" from:
1. almanakka.helsinki.fi
2. Finnish/English Wikipedia
3. http://www.finnguide.fi/calendar (not sure if this is ok)
in this order of preference.

I also moved some to categories (not entirely sure if they're okay and there's still work to be done there but anyway). Also the comment about Annunciation.
Comment 3 Lasse Liehu 2011-10-18 23:26:59 UTC
Created attachment 64686 [details]
Fixed holiday_fi_fi

Fixed the problems (syntax, formatting, calculating Annunciation) in the latest attachment. Also everything but Leap Day is now categorised. It's done.
Comment 4 Lasse Liehu 2012-09-11 14:06:01 UTC
Any update on this? Are there still problems with the file? Thanks.
Comment 5 David E. Narvaez 2012-11-29 02:27:54 UTC
Git commit dead9348b739706c89bb44a4654e52c47917a7a4 by David E. Narváez.
Committed on 29/11/2012 at 03:27.
Pushed by narvaez into branch 'KDE/4.9'.

Updating Finnish holidays
FIXED-IN: 4.9.4

M  +124  -79   kholidays/holidays/plan2/holiday_fi_fi

http://commits.kde.org/kdepimlibs/dead9348b739706c89bb44a4654e52c47917a7a4