Bug 267578 - VCS commit dialog does not work by disabling the review plugin
Summary: VCS commit dialog does not work by disabling the review plugin
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: 4.2.0
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 4.2.0
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 20:37 UTC by Laszlo Papp
Modified: 2011-03-26 03:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Papp 2011-03-03 20:37:37 UTC 
Version:           4.2.0 (using KDE 4.6.0) 
OS:                Linux

Having disabled the review plugin in the settings, after a click on the commit action, I do not see any commit dialog any more, just the diff dialog at the bottom.

I think the review + commit activities should be separated regarding that, thus it should just work fine.

Reproducible: Always
Comment 1 Andrey Batyiev 2011-03-23 23:44:17 UTC 
Git commit c11a57c65eac89ff22fc53b9206d83fb889fc718 by generatorglukoff.
Committed on 23/03/2011 at 23:41.
Pushed by abatyiev into branch 'master'.

Make VcsCommitDialog useful as fallback, when no PatchReview plugin loaded

REVIEW: 100885
CCBUG: 267578

M  +11   -8    vcs/vcspluginhelper.cpp     
M  +50   -171  vcs/widgets/vcscommitdialog.cpp     
M  +9    -34   vcs/widgets/vcscommitdialog.h     
M  +29   -105  vcs/widgets/vcscommitdialog.ui     

http://commits.kde.org/kdevplatform/c11a57c65eac89ff22fc53b9206d83fb889fc718
Comment 2 Aleix Pol 2011-03-26 03:43:30 UTC 
Fixed by Andrey.

To Andrey: Can't you use BUG: to close bugs? in that case get in contact with an admin to get such privilege :) Thank you