Bug 265657 - "File Already Exists" dialogue window is too small to display useful information
Summary: "File Already Exists" dialogue window is too small to display useful information
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 271554 284161 292889 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-07 00:02 UTC by Alex
Modified: 2018-05-03 20:10 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
A screen cap of the dialogue window as it is currently (30.16 KB, image/jpeg)
2011-02-07 00:02 UTC, Alex
Details
See previous comment (48.67 KB, image/png)
2011-08-04 20:34 UTC, Radu-Cristian Fotescu
Details
See previous comment, again (49.71 KB, image/png)
2011-08-04 20:34 UTC, Radu-Cristian Fotescu
Details
This is how ut should have looked from the beginning (52.18 KB, image/png)
2011-08-04 20:35 UTC, Radu-Cristian Fotescu
Details
Copy dialog in SC 4.8 (441.78 KB, image/png)
2012-01-31 07:55 UTC, Cyril Brosch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2011-02-07 00:02:49 UTC
Created attachment 56933 [details]
A screen cap of the dialogue window as it is currently

Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

When performing a file operation (in Dolphin, for example), user is presented with a dialogue box entitled "File Already Exists", asking what to do.  In my case, the files both have icon previews, but those are all I can see unless I expand the window or scroll down.  After the dialogue is dismissed and the operation continues, when another conflict occurs, the dialogue is presented back in its original size, necessitating the resize again.

Reproducible: Always

Steps to Reproduce:
Copy or move a file into a directory containing a file of the same name.  The behaviour is exhibited both in Dolphin and Konqueror, and presumably any other KIO-using app dealing with files.

Actual Results:  
See attached screencap, please.

Expected Results:  
I would prefer that the window be sized initially to display such information as size and date, or that it retain the size previously set by the user (by dragging the window edge).

It was suggested by sreich of Freenode that I grep for the dialogue title.  I hope these results are of assistance (from kdelibs package source):

kio/kio/paste.cpp:                          i18n("File Already Exists"),
kio/kio/copyjob.cpp:                                   i18n("File Already Exists") : i18n("Already Exists as Folder"),
kio/kio/copyjob.cpp:                    err != ERR_DIR_ALREADY_EXIST ? i18n("File Already Exists") : i18n("Already Exists as Folder"),
kio/kio/global.cpp:      errorName = i18n( "File Already Exists" );
kio/kio/renamedialog.h: * The dialog shown when a CopyJob realizes that a destination file already exists,
kio/kio/job.cpp:                      job, i18n("File Already Exists"),
Comment 1 Cyril Brosch 2011-02-15 14:17:02 UTC
This one (introduced with SC 4.6, it was fine in 4.5.x) bugs me on my 13" notebook, too.
The size of the dialogue is fine on a 15" screen (or bigger), but for smaller screens there must another solution (maybe make the preview optional?).
Comment 2 Radu-Cristian Fotescu 2011-08-04 20:33:43 UTC
How can this bug be marked as UNCONFIRMED?!

Also, Cyril, it has nothing to do with the screen size -- it might have with the screen vertical _resolution_, but I'm not sure the dialog can really get larger (higher). It looks like it's "by design".

I'll attach the following:

copy_overwrite_1.png -> This is how the "File already exists" dialog is currently in KDE 4.6.x and 4.7.0. The icons are huge, but no details are in sight.

copy_overwrite_2.png -> In order to reach some relevant information, one has either to scroll down on *each* of the two files in conflict...

copy_overwrite_3.png -> ...or to enlarge the dialog manually. Actually, _this_ is the way this dialog should have shown up from the very beginning!
Comment 3 Radu-Cristian Fotescu 2011-08-04 20:34:30 UTC
Created attachment 62552 [details]
See previous comment
Comment 4 Radu-Cristian Fotescu 2011-08-04 20:34:48 UTC
Created attachment 62553 [details]
See previous comment, again
Comment 5 Radu-Cristian Fotescu 2011-08-04 20:35:17 UTC
Created attachment 62554 [details]
This is how ut should have looked from the beginning
Comment 6 Laurent 2011-08-26 09:55:16 UTC
Hi all, 

I confirm the bug exactly as it has been reported: reproductibility (always, any distribution, any hardware), birthdate (arrived in 4.6), degree of annoyance (major).
This is a small regression amongst many progresses from 4.5 to 4.6, but can really get on the nerves when doing punctual file management.

 I'll be eargerly waiting for the bugfix. ^^ Thanks for your hard work all ;)

  Best regards, 

     Laurent Lacôte
Comment 7 Christoph Feck 2011-10-16 08:48:34 UTC
*** Bug 284161 has been marked as a duplicate of this bug. ***
Comment 8 Christoph Feck 2011-10-16 08:51:35 UTC
*** Bug 271554 has been marked as a duplicate of this bug. ***
Comment 9 David Faure 2011-10-16 09:11:38 UTC
Todd? I just saw in the commit log that I actually had this reservation about the patch (reviewboard 3674), that it makes scrollbars appear by default.
Can you have a look?
Comment 10 Todd 2011-10-16 09:36:24 UTC
I thought there was a GSOC project that completely overhauled this dialog.  So is this issue still relevant?
Comment 11 David Faure 2011-10-16 19:41:22 UTC
Yes this is still relevant for KDE 4.x

The GSOC project will only be merged into KDE Frameworks 5.
Comment 12 Todd 2011-10-17 08:58:47 UTC
Alright.  As I said in the review, I didn't know how to make sure it was larger, which is why I didn't do it.  The behavior is the same as the previous version.
Comment 13 Adam Porter 2011-12-27 20:41:17 UTC
This should really be fixed before another KDE SC release.
Comment 14 Christoph Feck 2012-01-31 00:24:39 UTC
*** Bug 292889 has been marked as a duplicate of this bug. ***
Comment 15 Christoph Feck 2012-01-31 00:25:48 UTC
This is fixed in KDE 4.8, right?
Comment 16 Cyril Brosch 2012-01-31 07:54:14 UTC
Yes, it still has scroll bars, but the important parts are visible without the need to force a bigger window size (which I did as a workaround), look at the screenshot.
Comment 17 Cyril Brosch 2012-01-31 07:55:30 UTC
Created attachment 68362 [details]
Copy dialog in SC 4.8
Comment 18 Adam Porter 2012-01-31 14:39:37 UTC
Now the problem seems to be that, sometimes, after the window expands
to show the contents, the edges of the window end up off the screen.

On Tue, Jan 31, 2012 at 01:55, Cyril Brosch <info@cyrilbrosch.net> wrote:
> https://bugs.kde.org/show_bug.cgi?id=265657
>
>
>
>
>
> --- Comment #17 from Cyril Brosch <info cyrilbrosch net>  2012-01-31 07:55:30 ---
> Created an attachment (id=68362)
>  --> (http://bugs.kde.org/attachment.cgi?id=68362)
> Copy dialog in SC 4.8
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are a voter for the bug.
> You are on the CC list for the bug.
Comment 19 Milko Krachounov 2013-10-22 18:14:45 UTC
Another problem with the present window is that the size changes, sometimes when you're about to confirm the operation. It's inconvenient to have the button you're about to click move away from your mouse. The situation where I need the information in the window is rarer than the situation where I just want to confirm.

More so when I'm moving to a kioslave that doesn't support information display (the information on the local file is as good as useless if I don't get the information about the remove file as well).
Comment 20 Christoph Feck 2013-10-22 19:23:22 UTC
Milko, please do not add more issues to existing bug reports. What you see has already been reported as bug 299501 and bug 275112.
Comment 21 Nate Graham 2018-05-03 20:10:48 UTC
Works for me in KDE Frameworks 5.45.