Bug 265580 - JJ: Window peek for minimized windows
Summary: JJ: Window peek for minimized windows
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-02-06 08:42 UTC by mbc111
Modified: 2012-03-11 14:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch with desired behavior (2.49 KB, patch)
2011-10-29 16:13 UTC, Radu 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description mbc111 2011-02-06 08:42:44 UTC 
Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

The window highlight feature when hovering over taskbar previews does not show minimized windows. This makes the use of the feature inconsistent. Furthermore, window highlight is most useful - imo - for digging up windows that one has minimized a long time about and forgotten about. I think that the behavior of Windows aero peek should be copied in this regard.

Reproducible: Always
Comment 1 Martin Flöser 2011-03-19 10:31:56 UTC 
needs just a w->enablePainting(PAINT_DISABLED_BY_MINIMIZE); in prePaintWindow() hook
Comment 2 Radu 2011-10-29 16:13:21 UTC 
Created attachment 65016 [details]
Patch with desired behavior

I've added a patch which I think will achieve the desired behaviour.
Comment 3 Martin Flöser 2011-10-30 11:17:34 UTC 
could you please add a review request on reviewboard.kde.org? Patches on bug reports get too easily lost
Comment 4 Thomas Lübking 2011-10-30 11:52:42 UTC 
glimpsed:
a) i guess "isInitiallyHidden" should be used in "::prePaintWindow()" and
b) please correct indention ;-)

Then create a review request, thanks.
Comment 5 Martin Flöser 2012-03-11 14:25:42 UTC 
seems to be fixed. At least I get previews for minimized windows :-)
Comment 6 Martin Flöser 2012-03-11 14:26:01 UTC 
(In reply to comment #5)
> seems to be fixed. At least I get previews for minimized windows :-)
err highlights
Comment 7 Thomas Lübking 2012-03-11 14:40:34 UTC 
yes is, https://git.reviewboard.kde.org/r/103404/
(luckily i patched it differently, so i truly had just forgotten about the bug and didn't steal the patch =)