Bug 265528 - Selection-painting tool bug with rotation + zoom-in
Summary: Selection-painting tool bug with rotation + zoom-in
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-05 17:12 UTC by animtim
Modified: 2011-05-09 10:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description animtim 2011-02-05 17:12:30 UTC
Version:           svn trunk
OS:                Linux

Take the selection painting tool, then rotate your canvas and zoom-in, un til you don't see the borders of your document. Then use the tool: it becomes "crazy" (it has wrong input coordinates or something like that I guess) .

Reproducible: Always
Comment 1 Dmitry Kazakov 2011-02-06 07:41:10 UTC
Good catch! It looks like it tries to autoscroll the canvas too much.
Comment 2 animtim 2011-02-08 19:46:03 UTC
I've noticed this bug affect every selection tools, every vector tools, every geometric tools, assistants and guides.. so very bad bug !!!
Comment 3 Dmitry Kazakov 2011-04-10 09:57:25 UTC
Git commit a1bc54466caf7066db145d8bab989c1d620084b6 by Dmitry Kazakov.
Committed on 13/03/2011 at 17:33.
Pushed by dkazakov into branch 'master'.

Fixed autoscrolling bug in Krita

I've extracted one method from KoToolProxy and overridden it in newly
created KisToolProxy. This method just converts widget coordinates
into document coordinates.

BUG:265528

M  +1    -0    krita/ui/CMakeLists.txt     
M  +2    -2    krita/ui/canvas/kis_canvas2.cpp     
A  +34   -0    krita/ui/canvas/kis_tool_proxy.cpp         [License: GPL (v2+)]
A  +33   -0    krita/ui/canvas/kis_tool_proxy.h         [License: GPL (v2+)]
M  +32   -9    libs/flake/KoToolProxy.cpp     
M  +5    -1    libs/flake/KoToolProxy.h     
M  +1    -1    libs/flake/KoToolProxy_p.h     

http://commits.kde.org/calligra/a1bc54466caf7066db145d8bab989c1d620084b6
Comment 4 Dmitry Kazakov 2011-05-09 10:30:03 UTC
Git commit 49f67ef803e98d259de7dbac01f91fc13746c57d by Dmitry Kazakov.
Committed on 13/03/2011 at 17:33.
Pushed by dkazakov into branch 'master'.

Fixed autoscrolling bug in Krita

I've extracted one method from KoToolProxy and overridden it in newly
created KisToolProxy. This method just converts widget coordinates
into document coordinates.

Fixed a bug reported by Thorsten.

WARNING: Be careful, the definition of 'document origin' differs in
Krita and other flake-based applications. In Krita 'origin' is used
only when the size of the image is less than the size of the image and
vast scrolling is disabled. It is used for centering and means "the
offset from the topLeft of the widget to the corner of the
document". In flake, 'origin' means "the offset of the document in a
big white rectangle that surrounds the document". Krita has no such
rectangle and the origin is used in a different way due to historical
reasons, i guess.

BUG:265528
CC:kimageshop@kde.org,t.zachmann@zagge.de

M  +1    -0    krita/ui/CMakeLists.txt     
M  +2    -2    krita/ui/canvas/kis_canvas2.cpp     
A  +34   -0    krita/ui/canvas/kis_tool_proxy.cpp         [License: GPL (v2+)]
A  +33   -0    krita/ui/canvas/kis_tool_proxy.h         [License: GPL (v2+)]
M  +32   -9    libs/flake/KoToolProxy.cpp     
M  +5    -1    libs/flake/KoToolProxy.h     
M  +1    -1    libs/flake/KoToolProxy_p.h     

http://commits.kde.org/calligra/49f67ef803e98d259de7dbac01f91fc13746c57d