Bug 265283 - Automatic marking of dependencies when removing a package makes it difficult to mark them for purging
Summary: Automatic marking of dependencies when removing a package makes it difficult ...
Status: RESOLVED FIXED
Alias: None
Product: muon
Classification: Unmaintained
Component: muon (show other bugs)
Version: 1.1.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Jonathan Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 13:34 UTC by Alvaro Manuel Recio Perez
Modified: 2011-02-03 20:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Manuel Recio Perez 2011-02-03 13:34:16 UTC
Version:           1.1.0 (using KDE 4.6.0) 
OS:                Linux

When the user marks a package for removal which other packages have dependencies on, Muon automatically marks all of them for removal too. In my opinion, there are two problems with this in the current implementation:

- If the user selected Purge instead, the dependent packages are still marked for removal and the user can't change that.

- Although Muon still show an enabled button for unmarking these packages, the button doesn't seem to do nothing when clicked and the no information is offered to the user explaining that behaviour (that this packages must remaing scheduled for removal as they depend on another package).

Reproducible: Always

Steps to Reproduce:
1. Select a package on which other packages depend.
2. Mark it for purging.

Actual Results:  
Muon marks for removal all package dependent on the initial package. The user can't either mark them for purging nor unmark them (and there's no feedback in the latter case).

Expected Results:  
Muon should offer a way to change the mark of a package scheduled for removal to purging and viceversa.

Optionally, it could also let the user unmark it which would trigger the unmarking for removal or purging of its dependencies. At least, if the unmark button is still enabled in this case, Muon should inform the user about why he can't unmark the package when it has dependencies.

OS: Linux (x86_64) release 2.6.35-25-generic
Compiler: cc
Comment 1 Jonathan Thomas 2011-02-03 19:32:59 UTC
Git commit d16952291c73f3f539f58f9f34aa91e1e0740d68 by Jonathan Thomas.
Committed on 03/02/11 at 15:44.
Pushed by jmthomas into branch '1.1'.

Don't call queryExit() when the "Quit" KAction is called. KApplication::instance()->quit() already calls it for us.
This prevents double exit confirmation when quit via File -> Quit or the Quit toolbar button in the Muon Updater.

BUG:265283

M  +1    -3    libmuon/MuonMainWindow.cpp     

http://commits.kde.org/muon/d16952291c73f3f539f58f9f34aa91e1e0740d68
Comment 2 Jonathan Thomas 2011-02-03 19:32:59 UTC
Git commit a5f89d5cfc39d9cfd2ec053391a07e90de0088d6 by Jonathan Thomas.
Committed on 03/02/11 at 15:44.
Pushed by jmthomas into branch 'master'.

Don't call queryExit() when the "Quit" KAction is called. KApplication::instance()->quit() already calls it for us.
This prevents double exit confirmation when quit via File -> Quit or the Quit toolbar button in the Muon Updater.

BUG:265283

M  +1    -3    libmuon/MuonMainWindow.cpp     

http://commits.kde.org/muon/a5f89d5cfc39d9cfd2ec053391a07e90de0088d6
Comment 3 Jonathan Thomas 2011-02-03 20:22:34 UTC
Git commit 3591c44ccc56b1085412cf5ea5dcd68bfaa76e51 by Jonathan Thomas.
Committed on 03/02/11 at 20:19.
Pushed by jmthomas into branch '1.1'.

Show the purge button when a package is set to be removed, in case the user wants to purge the dependencies automatically set for removal.
CCBUG:265283

M  +4    -2    libmuon/DetailsTabs/MainTab.cpp     

http://commits.kde.org/muon/3591c44ccc56b1085412cf5ea5dcd68bfaa76e51
Comment 4 Jonathan Thomas 2011-02-03 20:33:40 UTC
Oops, those first two messages were meant for the other bug... :P

Anyways, I've made it possible to purge packages if they are already marked for removal. In addition, for 1.2 I've made it possible to mark multiple packages at once via a context menu, which should make the situation a lot more convenient.