Bug 264802 - Software groups icons partyally hidden in GNOME PackageKit
Summary: Software groups icons partyally hidden in GNOME PackageKit
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-29 23:49 UTC by nucleo
Modified: 2011-07-29 23:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description nucleo 2011-01-29 23:49:06 UTC 
Version:           unspecified
OS:                Linux

Software groups icons partyally hidden in GNOME PackageKit.



Reproducible: Always


Actual Results:  
See screenshot:
http://img64.imageshack.us/img64/2679/gnome5.png

Expected Results:  
When Clearlooks used:
http://img171.imageshack.us/img171/2679/gnome5.png
Comment 1 Hugo Pereira Da Costa 2011-01-30 13:05:18 UTC 
I know what it is.
We force gtk_tree_view_set_show_expanders() to be able to draw our custom treelines. This works fine for all lists we've seen so far but this one.

Maybe its because we set the flag too late (might need to be set before widget realization). 

Still investigating.
Comment 2 Hugo Pereira Da Costa 2011-01-30 13:17:17 UTC 
Git commit 1290011d30790e99dd04ec85b07da0607f1b22f4 by Hugo Pereira Da Costa.
Pushed by hpereiradacosta into branch '1.0'.

Do not force gtk_tree_view_set_show_expanders to true in TreeViewData
Check on gtk_tree_view_get_show_expanders to decide on whether tree lines should be painted or
not. No expander, no tree lines.
CCBUG: 264802

M  +1    -2    src/animations/oxygentreeviewengine.cpp     
M  +3    -1    src/oxygenstylewrapper.cpp     

http://commits.kde.org/d1a86b4e/1290011d30790e99dd04ec85b07da0607f1b22f4
Comment 3 Hugo Pereira Da Costa 2011-01-30 13:17:45 UTC 
That fixes it.
I do not think it introduces any regression.
Comment 4 nucleo 2011-01-30 14:57:12 UTC 
Yes, it fixed in gpk and tree view fine in other apps.
http://img132.imageshack.us/img132/9532/gnomeu.png