Created attachment 56502 [details] Test data Version: git commit 6ea30bc370b7eb5223e322fc6ee596cee00d19a9 (using KDE 4.4.3) OS: Kubuntu 10.04 Test data is in MS Powerpoint 2007 format which has picture and text in it. Open the same document in Calligra Stage, and observe the display of Picture. Expected outcome: Text and Picture should be displayed clearly as like in the mspowerpoint 2007 file. Actual outcome: Text is displaying across the picture. Please check the screenshots attached.
Created attachment 56504 [details] Screenshot in MS Powerpoint
Created attachment 56505 [details] Screenshot in Calligra Stage
There is now a big black border on the right and left of the image
*** Bug 264467 has been marked as a duplicate of this bug. ***
Git commit 87a13b950005a28cba23da34bd98dbbb7b90afbb by Lukáš Tvrdý. Committed on 03/08/2011 at 17:10. Pushed by lukast into branch 'master'. Fix the black border of the image o make the pixels transparent BUG:264467 CCBUG:264471 M +8 -7 filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h http://commits.kde.org/calligra/87a13b950005a28cba23da34bd98dbbb7b90afbb
The underline is not a filter issue: it's in the drawing of lines of text. The text-through-image issue has to do with font metrics differing on Windows and other systems, so we'll have to live with that.
Found the reason for the text across the image as well. Nothing to do with font stuff; kotextloader doesn't apply the style if we don't load any text for a line. There's an empty line with just a linebreak that if it would have the right style would have a bigger font (32 instead of 12) and that would push the text down enough.
Git commit 93352ed72216d403c39f6c773e1c86c56ca944f4 by Boudewijn Rempt. Committed on 17/08/2011 at 16:30. Pushed by rempt into branch 'master'. fix painting of paragraph decorations for multi-line text fragments While iterating over the lines of a multi-line text fragment to paint the decorations line by line, the start position of the area we paint wouldn't increase. If you had a fragment starting after the beginning of a line, for all lines, the start position for painting decorations would be there, instead of at the beginning of the next line. CCBUG: 264471 M +46 -7 libs/textlayout/KoTextLayoutArea_paint.cpp http://commits.kde.org/calligra/93352ed72216d403c39f6c773e1c86c56ca944f4
Created attachment 62901 [details] document to show the fix with the underlines.
The underline part also fixes issues with multiline underlines -- see the attached odt.
Git commit 2fc2b38ffd0d1aedcbb51bdf5e0810f34bd74f8e by Boudewijn Rempt. Committed on 18/08/2011 at 09:07. Pushed by rempt into branch 'master'. Use the start of the line to determine paragraph decorations For multi-line text fragments, the decoration on all lines after the first line start at the beginning. This simplifies the code a lot. CCBUG: 264471 M +26 -18 libs/textlayout/KoTextLayoutArea_paint.cpp http://commits.kde.org/calligra/2fc2b38ffd0d1aedcbb51bdf5e0810f34bd74f8e
Git commit 099217dbc996a0020c228d835ba59492d17be23b by Boudewijn Rempt. Committed on 18/08/2011 at 09:35. Pushed by rempt into branch 'master'. Insert an invisible space if we have an empty text span For empty spans, we would set the style, load the span, do nothing except increase the span depth and then unset the style. This change inserts an invisible space (http://www.unicode.org/charts/PDF/U2000.pdf) so the the style doesn't get lost. BUG: 264471 M +6 -0 libs/kotext/opendocument/KoTextLoader.cpp http://commits.kde.org/calligra/099217dbc996a0020c228d835ba59492d17be23b
Verified in 85115210810acc59bd34f77251a616e5ca9e00e0 .
Verified in 85115210810acc59bd34f77251a616e5ca9e00e0
Reopening as I am reverting the commit. We sholdn't add blank characters. In fact lowriter displays the converted document just as bad as we do. The bug is in the filter eventhough we have now gained some understanding