Bug 264058 - Middle click to close tab selects that tab
Summary: Middle click to close tab selects that tab
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: tabbing (show other bugs)
Version: 4.6.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-23 11:54 UTC by Martin Kampas
Modified: 2012-10-12 21:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Kampas 2011-01-23 11:54:48 UTC
Version:           4.6.0 (using KDE 4.5.95) 
OS:                Linux

IIRC, it used to be possible to close other tab "silently" using middle click. Now the behavior changed and middle-clicking on a tab first make it visible, then close. As a result, the tab left to the closed tab becomes the visible one.

Reproducible: Always

Steps to Reproduce:
1. Open three tabs
2. Select the first tab
3. Middle-click on the third tab to close it

Actual Results:  
The third tab becomes the visible one for a while, then it is closed and at the end the second tab becomes the visible one.

Expected Results:  
The third tab should disappear silently and the first tab should remain the visible one.

OS: Linux (x86_64) release 2.6.36-gentoo-r5
Compiler: x86_64-pc-linux-gnu-gcc
Comment 1 Burkhard Lück 2011-05-12 11:41:24 UTC
Checked this issue with Kubuntu 10.10 (kde 4.6.2) and master/branch 4.6 compiled from sources.

The third tab disappears silently and the first tab remains the visible one, this is the result you expected.

Please try again with an up to date kde, thanks.
Comment 2 Martin Kampas 2011-05-13 06:42:35 UTC
Checked with KDE 4.6.2 (on Gentoo), the behavior is still the same.

I noticed there is a (new?) option in General section "Activate previously used tab when closing the current tab" - with this enabled, it *partially* works: at the end the first tab is the visible one, but it still brings the third tab info foreground for a while.

This causes unnecesary redrawing, reswapping memory if the tab has not been used for some time etc. and as a result it takes a noticeable amount of time to close a background tab (2 cores @1600MHz, 3.3GB RAM in my case).
Comment 3 Dawit Alemayehu 2011-06-29 03:43:34 UTC
confirmed. Use the RMB and selected close tab when the context menu shows up does not show the same side effect.
Comment 4 Dawit Alemayehu 2012-10-12 21:57:43 UTC
Git commit f8309bec7316e6bb6ff90b76cc99c798ff045f6f by Dawit Alemayehu.
Committed on 27/09/2012 at 08:08.
Pushed by adawit into branch 'KDE/4.9'.

If the "Middle click on tab to close" option is checked, do not select the
tab when the MMB is clicked on it. Instead simply close the tab.
FIXED-IN: 4.9.3
REVIEW: 106615

M  +32   -13   konqueror/src/konqtabs.cpp
M  +7    -0    konqueror/src/konqtabs.h

http://commits.kde.org/kde-baseapps/f8309bec7316e6bb6ff90b76cc99c798ff045f6f