Bug 263755 - Quick Tile shortcuts should be toggle buttons
Summary: Quick Tile shortcuts should be toggle buttons
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: core (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: 4.11
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 15:24 UTC by Kai Uwe Broulik
Modified: 2013-05-18 18:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Make QuickTile shortcut act as toggle (573 bytes, patch)
2011-01-20 20:02 UTC, Thomas Lübking
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2011-01-20 15:24:20 UTC
Version:           unspecified (using KDE 4.5.95) 
OS:                Linux

I have configured KWin to snap windows to the corners (this Aero Snap thingie) using keystrokes (Meta+Left and Meta+Right). I noticed that this affects Plasma extenders as well, so they get maximized to the left half of the screen or right half, depending on the keystroke. Maximizing keystroke maximizes the extender. Using a fullscreen keystroke (in my case Alt-F11) makes the extender fill the whole screen.

Reproducible: Always
Comment 1 Kai Uwe Broulik 2011-01-20 15:25:39 UTC
And they retain their shape even after closing it, so now I got a network manager plasmoid that fills the right half of the screen and I cannot resize it smaller since resizing this extender doesn‘t work.
Comment 2 Aaron J. Seigo 2011-01-20 16:42:53 UTC
these probably should not be applied to such windows which have asked not to be managed ..
Comment 3 Martin Flöser 2011-01-20 16:59:54 UTC
Concerning quick tile it's more difficult as it's a proprietary KWin enhancement. It respects only move/resize. From that I assume that alt+click also influences those extenders.

I think this is another case for "we need a window class for the desktop shell". Something for next Tokamak.
Comment 4 Kai Uwe Broulik 2011-01-20 17:04:24 UTC
Yes, Alt+Mouse also affects them but I didn‘t wrote that since some extenders do use the mouse and you can drop them on the desktop (I think the calendar does something like that?) but yes, this also affects them.
Well but not only quick tile (ah, that‘s the term, right :P) affects, but also the standard maximizing keystroke. The keystroke for moving also lets them being moved, and alt-f5 minimizes them.
Comment 5 Thomas Lübking 2011-01-20 18:47:19 UTC
@Aaron
if you can use alt+l/rmb on a window it should not have (and probably does not have) the "override" type, so those extenders should maybe just use it then =P
(i only tested with "wall ding" -> notification, but that's a _NET_WM_WINDOW_TYPE_DOCK)

@Martin:
why should "quick tiling" /not/ respect (_NET_WM_ALLOWED_ACTIONS & _NET_WM_ACTION_MAXIMIZE_VERT) or just Client::isMaximizable()
ie., what's the point in allowing explixitly non maximizable clients to "pseudo v'max" - notably since they'll implicitly get the _NET_WM_STATE_MAXIMIZED_VERT property by the set geometry (probably only iff allowed)
(in doub't: just don't paint the tile hint either =)

@Kai-Uwe
if you can use alt+mouse to move windows, you can also use the right mousebutton to freely resize the window - the max'd state will be removed by this (unless the extender was smart enough to setFixedSize() - then you're doomed but it's also a bug in the extender ;-)
Comment 6 Martin Flöser 2011-01-20 18:54:16 UTC
> @Martin:
> why should "quick tiling" /not/ respect (_NET_WM_ALLOWED_ACTIONS &
> _NET_WM_ACTION_MAXIMIZE_VERT) or just Client::isMaximizable()
> ie., what's the point in allowing explixitly non maximizable clients to
> "pseudo v'max" - notably since they'll implicitly get the
> _NET_WM_STATE_MAXIMIZED_VERT property by the set geometry (probably only
> iff allowed)
> (in doub't: just don't paint the tile hint either =)
Because it's not really maximizing and wouldn't solve the problem... xprops of 
the calendar:
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, 
_NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_VERT, 
_NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_FULLSCREEN, 
_NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE
Comment 7 Martin Flöser 2011-01-20 18:56:20 UTC
changing to wishlist as it's not really a bug and needs change in currently correct behavior (considering the allowed actions shown in comment #6)
Comment 8 Thomas Lübking 2011-01-20 19:39:43 UTC
I think this could (actually only) be "solved" by making the shortcut a toggle.

A "_NET_WM_DO_NOT_REACT_ON_QUICK_TILE_SHORTCUT" is rather not in the cards and one cannot prevent windows from being undecorated, yet managed (since they'd all be affected by this, not only some plasma extenders)
Comment 9 Thomas Lübking 2011-01-20 20:02:00 UTC
Created attachment 56251 [details]
Make QuickTile shortcut act as toggle

the maximize shortcut works this way as well (yes - i've maximized a window to test this, now bash me ;-)
Comment 10 Martin Flöser 2013-05-18 18:23:28 UTC
seems to be implemented in master.