Bug 263497 - Colour preview gets stuck after changing colour scheme
Summary: Colour preview gets stuck after changing colour scheme
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (show other bugs)
Version: 1.0
Platform: Chakra Linux
: NOR normal
Target Milestone: ---
Assignee: Matthew Woehlke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 01:04 UTC by ojrajala
Modified: 2011-07-22 18:11 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ojrajala 2011-01-18 01:04:13 UTC 
Version:           1.0 (using KDE 4.5.95) 
OS:                Linux

Sometimes when browsing through colour schemes, the preview box gets stuck in one theme. This happens after applying new scheme.

Reproducible: Sometimes

Steps to Reproduce:
Select a different colour scheme, press Apply. 
Select another scheme in list.

Actual Results:  
The view in preview box is same as scheme currently in use.

Expected Results:  
Preview box should change according to selection.

OS: Linux (x86_64) release 2.6.37-CHAKRA
Compiler: gcc
Comment 1 Pyroman 2011-03-06 12:31:33 UTC 
Same problem appears in KDE 4.6.1.
Color scheme preview shows only links colors changes.

Kubuntu 10.10 Maverick, 32 bit. Qt 4.7.0.
Comment 2 Ivan Efremov 2011-03-06 15:17:57 UTC 
gentoo, kde 4.6.0 with qt 4.7.1 - same problem
Reproducible: every time
Comment 3 Ivan Efremov 2011-03-06 15:19:18 UTC 
*** This bug has been confirmed by popular vote. ***
Comment 4 Craig Lillie 2011-03-16 23:07:04 UTC 
I demand a re-count!   No wait, it happened to me as well! ;)
Comment 5 Jean-Baptiste Mardelle 2011-03-22 16:27:33 UTC 
Did some investigation and it seems related to changes in KGlobalSettings::createApplicationPalette, see git commit:

http://quickgit.kde.org/index.php?p=kdelibs.git&a=commitdiff&h=2f5cc437e11b4792e6a010ec98210e2f37a555d5

Since this change, the palette is cached and not recreated unless a global palette change occurs.

kcontrol/colors/previewwidget.cpp uses this function to create the preview palette, but since it now returns the cached palette, this does not work anymore.

So we need to think about how KGlobalSettings::createApplicationPalette should be used. We could for example add an extra parameter (temporaryPalette for example), that when set to true would not update the global applicationPalette var, but only return a temporary (not cached) palette... Hope it helps.
Comment 6 Pyroman 2011-05-08 20:05:20 UTC 
This bug is fixed in 4.6.3.