Version: unspecified (using KDE 4.5.95) OS: Linux In KDE 4.6 you can close windows directly from the Present Window Grid. When closing the last window, the Grid effect doesn‘t disapper. You need to click somewhere or press Escape to return to normal desktop. Reproducible: Couldn't Reproduce
Btw thanks for all the reported bugs.
No problem :) I just want to prove that KDE can be as elegant and shiny as Mac OS X :P
Created attachment 57130 [details] Make Present disappear when closing last window Since this is a junior job and I wanted to start helping with KDE Development I thought I might as well start here. Turned out it was easier than I thought. The patch (against git-master) is attached and always deactivates the presentWindows as soon as no more windows are there to be highlighted. This might also fix a TODO in line 849. I didn't remove the comment, but the maintainer or whoever is responsible may feel free to remove it. I also added the maintainer / author of the plugin to CC
On Thursday 10 February 2011 22:29:24 Marcus Hähnel wrote: > Created an attachment (id=57130) > --> (http://bugs.kde.org/attachment.cgi?id=57130) > Make Present disappear when closing last window thanks for the patch, but I doubt that it will work. w will also be null when filtering and not matching anything. You might want to open a review request on git.reviewboard.kde.org - it's more suited to patch review and I get here something like 20 to 30 bug mails per day, so it's easily missed ;-)
Created attachment 57149 [details] Make Present disappear when closing last window Ok. You're right. I totaly forgot about the filter. I posted an updated patch to the reviewboard (thanks for the hint) that only closes the view if there are no more managedWindows. This does not look as elegant as the first patch, but it actually works ;) I just attach the patch here for completeness sake.
Git commit 72a41e5df7addf1ba00567473b7376222bd0ded4 by Martin Gr����lin. Committed on 06/03/2011 at 19:08. Pushed by graesslin into branch 'master'. End PresentWindows effect after last window closed Thanks to Marus H��hnel for this contribution to KDE. CCMAIL: marcus@mh-development.info FEATURE: 262540 FIXED-IN: 4.7.0 REVIEW: 100627 M +7 -0 kwin/effects/presentwindows/presentwindows.cpp http://commits.kde.org/kde-workspace/72a41e5df7addf1ba00567473b7376222bd0ded4
This doesn‘t count as bug fixing? So not in 4.6.2 :(
> This doesn‘t count as bug fixing? No, that's clearly a feature and I was surprised that this bug was not opened as a wishlist ;-) > So not in 4.6.2 :( Sorry, it could introduce new bugs, therefore a no-go for stable release