Bug 262232 - untranslatable unit "KiB/s" in jobwidget.cpp
Summary: untranslatable unit "KiB/s" in jobwidget.cpp
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: notifications (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 20:42 UTC by Alexander Potashev
Modified: 2011-01-06 00:46 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (26.73 KB, image/png)
2011-01-05 20:42 UTC, Alexander Potashev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2011-01-05 20:42:25 UTC
Created attachment 55625 [details]
screenshot

Version:           unspecified (using KDE 4.5.90) 
OS:                Linux

In kdebase/workspace/plasma/generic/applets/notifications/ui/jobwidget.cpp, line 65:
    m_plotter->setUnit("KiB/s");

Please, make this translatable.

Reproducible: Always
Comment 1 Christoph Feck 2011-01-05 21:05:19 UTC
Maybe it is even possible to combine it with KLocale::formatByteSize() so that it shows "KB" instead of "KiB" on systems where it is configured to do so.
Comment 2 Albert Astals Cid 2011-01-05 23:52:21 UTC
SVN commit 1212155 by aacid:

Use binaryUnitDialect, also make the strings translatable
BUGS: 262232


 M  +15 -1     jobwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212155
Comment 3 Albert Astals Cid 2011-01-05 23:54:44 UTC
SVN commit 1212156 by aacid:

backport r1212155 | aacid | 2011-01-05 22:51:16 +0000 (Wed, 05 Jan 2011) | 3 lines

Use binaryUnitDialect, also make the strings translatable
BUGS: 262232


 M  +15 -1     jobwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212156
Comment 4 Albert Astals Cid 2011-01-06 00:45:22 UTC
SVN commit 1212167 by aacid:

I just realized it does not make sense to be smart about the unit to show if i don't change how calculations are done so revert the code that sets kib or kb
Might make sense to open a different bug about compliance with the binary unit of user choice
CCBUGS: 262232


 M  +0 -14     jobwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212167
Comment 5 Albert Astals Cid 2011-01-06 00:46:02 UTC
SVN commit 1212168 by aacid:

I just realized it does not make sense to be smart about the unit to show if i don't change how calculations are done so revert the code that sets kib or kb
Might make sense to open a different bug about compliance with the binary unit of user choice
CCBUGS: 262232


 M  +0 -14     jobwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1212168