Bug 261207 - Folder view icon label height does not follow icon size
Summary: Folder view icon label height does not follow icon size
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-folderview (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-25 08:55 UTC by d.lecardez
Modified: 2012-02-12 18:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description d.lecardez 2010-12-25 08:55:58 UTC
Version:           unspecified (using KDE 4.5.4) 
OS:                Linux



didier83

Registered Member
En ligne

Messages: 1

Karma: 0

Gender:  Male

OS: Fedora Fedora

France
Folder view icon size

Hello,

I'm using KDE 4.5.4
On a Folder View Widget, I want to reduce the icon size of the items list.
To do so I go to:

Folder View Settings--> Display

The icon size adjustment is performed using the 'Size' slider.
Changing the size of the icon also changes accordingly the height of this icon container (OK).
The problem is that at some point when you reduce the icon size, the container stop reducing. This means if you want to use small icon, its container is much too high in respect.
Any idea on how to have a small icon with a small icon container ?

NOTE: KDE 4.4.5 does not have this problem.

The bad one:  http://d.lecardez.free.fr/temp/MenuBad.jpg
The good one: http://d.lecardez.free.fr/temp/MenuOK.jpg

Reproducible: Always

Steps to Reproduce:
See details section

Actual Results:  
container icon height does not follow icon size when using small icons

Expected Results:  
Have the same KDE 4.4.5 behaviour
Comment 1 Beat Wolf 2010-12-25 09:15:16 UTC
did you edit the "good" picture by yourself or is there actually a way to achieve it?
Comment 2 d.lecardez 2010-12-25 09:23:13 UTC
(In reply to comment #1)
> did you edit the "good" picture by yourself or is there actually a way to
> achieve it?


I get the good picture using an other bootable fedora FC12 system running KDE 4.4.5

I discovered this problem migrating to fedora FC14 running KDE 4.5.4
Comment 3 Ignat Semenov 2012-02-03 13:29:59 UTC
Git commit c2d6531eaa88ded657efd6b636b9905a7df6ec33 by Ignat Semenov.
Committed on 03/02/2012 at 14:27.
Pushed by isemenov into branch 'master'.

Do not account for the vertical frame margins in the listview item size calculation to save vertical space.
FIXED-IN:4.8.1

M  +1    -2    plasma/applets/folderview/listview.cpp

http://commits.kde.org/kde-baseapps/c2d6531eaa88ded657efd6b636b9905a7df6ec33
Comment 4 Ignat Semenov 2012-02-03 13:32:20 UTC
Git commit 8880bcb08d115a0fbab687ec7bef74765c72b7a2 by Ignat Semenov.
Committed on 03/02/2012 at 14:27.
Pushed by isemenov into branch 'KDE/4.8'.

Do not account for the vertical frame margins in the listview item size calculation to save vertical space.
FIXED-IN:4.8.1

M  +1    -2    plasma/applets/folderview/listview.cpp

http://commits.kde.org/kde-baseapps/8880bcb08d115a0fbab687ec7bef74765c72b7a2
Comment 5 Ignat Semenov 2012-02-12 18:20:12 UTC
Git commit 303e963f4e94c00ec7d3d58b8409be83531ce600 by Ignat Semenov.
Committed on 12/02/2012 at 19:14.
Pushed by isemenov into branch 'master'.

correctly apply text line count settings in list view

1)Apply the text line count setting in updateListViewState() - removed an incorrect pointer check
2)Relayout the items in the list view on text line count change and recalculate the list view size

This correctly fixes bug 261207, as it allows the user to set the text line count to 1, thus saving vertical space.
FIXED-IN:4.8.1

M  +1    -3    plasma/applets/folderview/folderview.cpp
M  +1    -1    plasma/applets/folderview/listview.cpp

http://commits.kde.org/kde-baseapps/303e963f4e94c00ec7d3d58b8409be83531ce600
Comment 6 Ignat Semenov 2012-02-12 18:20:59 UTC
Git commit 7b259cc4182fc875b80f4da3d02c4f05142567d4 by Ignat Semenov.
Committed on 12/02/2012 at 19:14.
Pushed by isemenov into branch 'KDE/4.8'.

correctly apply text line count settings in list view

1)Apply the text line count setting in updateListViewState() - removed an incorrect pointer check
2)Relayout the items in the list view on text line count change and recalculate the list view size

This correctly fixes bug 261207, as it allows the user to set the text line count to 1, thus saving vertical space.
FIXED-IN:4.8.1

M  +1    -3    plasma/applets/folderview/folderview.cpp
M  +1    -1    plasma/applets/folderview/listview.cpp

http://commits.kde.org/kde-baseapps/7b259cc4182fc875b80f4da3d02c4f05142567d4