Bug 261159 - Wrong sliding animation for top edge autohide panels on screens with y-offset greater than 0
Summary: Wrong sliding animation for top edge autohide panels on screens with y-offset...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-24 15:29 UTC by Simon Paridon
Modified: 2018-08-09 12:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Paridon 2010-12-24 15:29:51 UTC
Version:           unspecified (using KDE 4.5.90) 
OS:                Linux

This is not the exact same issue, but is closely related: My second screen has an offset of 56 Pixels from the top, i.e., virtual desktop is 1080p in height, and the second screen shows the lower 1024 pixels of this in height.

Now, if you have an autohide panel at the top screen edge, it will correctly appear on the screen at virtual position y=56. But the scroll-in animation is wrong, it appears like it would if it was aligned to the bottom edge. I guess there's a check somewhere like "if (y==0) top_edge_anim(); else bottom_edge_anim();" which is incorrect in this special case.

Reproducible: Always

Steps to Reproduce:
- Set the virtual y position of the second screen to a value greater than 0
- Add an auto-hide panel and position it at the top screen edge
- Move the mouse to the screen edge to make the panel appear

Actual Results:  
The panel gets shown immediately with some spacing to the upper edge, then moves up to its correct position. When hiding, it moves back down.

Expected Results:  
It should move down at the beginning, emerging from "under" the edge, and then slip back up in the end.

Possibly related to https://bugs.kde.org/show_bug.cgi?id=253211
Comment 1 Martin Flöser 2011-12-10 21:41:56 UTC
Git commit cbdd7295d100b19ec55d4b88f2a8113095439e26 by Martin Gräßlin.
Committed on 10/12/2011 at 12:31.
Pushed by graesslin into branch 'master'.

Fixing incorrect clipping of sliding popups

Make use of new extension of protocol for magic number -1.
If offset is -1 KWin has to decide the offset. This fixes all the
incorrect animations and allows us to perform clipping again by
filtering out the window quads which should not be visible.

Additionally the effect now sanitizes the offset. That is for e.g.
Yakuake setting an offset of 0, but there is a strut on the top
corner causing Yakuake not to appear on 0, but with an offset of
the strut. Such cases are now considered as well and the animation
is fixed.

REVIEW: 103367
BUG: 287602
CCBUG: 261159
CCBUG: 278760
FIXED-IN: 4.8.0

M  +115  -37   kwin/effects/slidingpopups/slidingpopups.cpp

http://commits.kde.org/kde-workspace/cbdd7295d100b19ec55d4b88f2a8113095439e26
Comment 2 Vlad Zahorodnii 2018-08-09 12:08:30 UTC
Can't reproduce it.