Bug 261001 - Wish: better integration on OS X
Summary: Wish: better integration on OS X
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources macOS
: NOR wishlist
Target Milestone: ---
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-22 20:50 UTC by Christoph Vogtländer
Modified: 2010-12-22 23:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
diff against #1208665 activating requested features (896 bytes, patch)
2010-12-22 20:50 UTC, Christoph Vogtländer 		Details
current look of skrooge on OS X (27.29 KB, image/png)
2010-12-22 20:56 UTC, Christoph Vogtländer 		Details
skrooge with requested changes (26.33 KB, image/png)
2010-12-22 20:56 UTC, Christoph Vogtländer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Vogtländer 2010-12-22 20:50:40 UTC 
Created attachment 55168 [details]
diff against #1208665 activating requested features

Version:           unspecified (using KDE 4.5.3) 
OS:                OS X

It would be great if unified toolbar and tab document mode could be activated. This would integrate skrooge better into OS X. See attached screenshots. Only two lines of code are needed (see attached diff against rev #1208665). Activating the unified toolbar definitely has no side effects on other operating systems. I'm not sure about document mode, though (see http://doc.qt.nokia.com/stable/qtabbar.html#documentMode-prop).

Reproducible: Didn't try
Comment 1 Christoph Vogtländer 2010-12-22 20:56:10 UTC 
Created attachment 55169 [details]
current look of skrooge on OS X
Comment 2 Christoph Vogtländer 2010-12-22 20:56:50 UTC 
Created attachment 55170 [details]
skrooge with requested changes
Comment 3 Stephane MANKOWSKI 2010-12-22 21:59:49 UTC 
SVN commit 1208683 by smankowski:

BUG: 261001: Better integration on OS X

 M  +1 -0      CHANGELOG  
 M  +1 -0      skgbasegui/skgmainpanel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1208683
Comment 4 Christoph Vogtländer 2010-12-22 22:15:39 UTC 
what about the unified toolbar? Is this something to be made upstream in kdelibs? should i make a wish for that?
Comment 5 Stephane MANKOWSKI 2010-12-22 23:16:49 UTC 
SVN commit 1208703 by smankowski:

BUG: 261001: Better integration on OS X

 M  +1 -0      skguniqueapplication.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1208703
Comment 6 Stephane MANKOWSKI 2010-12-22 23:17:34 UTC 
Sorry, I missed a part of the correction.