Bug 260815 - grouping windows should unhide the titlebar
Summary: grouping windows should unhide the titlebar
Status: REPORTED
Alias: None
Product: Oxygen
Classification: Plasma
Component: win deco (show other bugs)
Version: 4.0
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 19:01 UTC by qqqqqqqqq9
Modified: 2011-04-02 10:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Without titlebar (12.40 KB, image/png)
2010-12-20 21:40 UTC, qqqqqqqqq9
Details
with title (29.24 KB, image/png)
2010-12-20 21:41 UTC, qqqqqqqqq9
Details
Shaded window without titlebar (3.40 KB, image/png)
2010-12-20 21:47 UTC, qqqqqqqqq9
Details

Note You need to log in before you can comment on or make changes to this bug.
Description qqqqqqqqq9 2010-12-20 19:01:40 UTC
Version:           SVN (using KDE 4.5.85) 
OS:                Linux

Some features like shading windows or using the tabbed window feature don't make sense/ are pratically unusable with a hidden titlebar. It would be helpful, if the titlebar  would be automatically unhidden in such cases.

Reproducible: Didn't try

Steps to Reproduce:
1. Have a window with no titlebar (very cool on small screens)
2. Shade this window

Actual Results:  
The window is shaded to a small strip which cannot be moved and is easily to overlook.

Expected Results:  
The titlebar should be shown for shaded windows.
Comment 1 Martin Flöser 2010-12-20 19:06:34 UTC
how do you shade a window without titlebar? I just set "no border" and shade 
is not available any more...
Comment 2 qqqqqqqqq9 2010-12-20 21:00:03 UTC
Either via shortcut that can be set, or through the window actions menu (Alt+F3). With border but no title Shading and Unshading itself works flawless. After shading i end up with just the border and no window in it. This takes fokus and can be easily unshaded again.
Comment 3 Martin Flöser 2010-12-20 21:22:22 UTC
Sorry, but I do not get what you mean. When I disable borders I cannot shade 
the window through Alt+F3. It is disabled. Furthermore I do not get what the 
difference between "border" and "title" is for you. I assumed you mean the 
same with it, but then your last comment does not make sense at all.
Comment 4 Thomas Lübking 2010-12-20 21:37:26 UTC
client.cpp:715
--------------
bool Client::userCanSetNoBorder() const
    {
    return !isFullScreen() && !isShade() && ( clientGroup() == NULL || !(clientGroup()->items().count() > 1));
    }

void Client::setNoBorder( bool set )
    {
    if( !userCanSetNoBorder() )
        return;

client.cpp:983
-------------
bool Client::isShadeable() const
    {
    return !isSpecialWindow() && !noBorder();
    }

void Client::setShade( ShadeMode mode )
    {
    if( !isShadeable())
        return;
.....

-> borderless windows cannot be shaded and shaded windows cannot be un-bordered.

Please ensure you're actually using kwin and not compiz.
Comment 5 qqqqqqqqq9 2010-12-20 21:40:10 UTC
Created attachment 55111 [details]
Without titlebar
Comment 6 qqqqqqqqq9 2010-12-20 21:41:33 UTC
Created attachment 55112 [details]
with title
Comment 7 qqqqqqqqq9 2010-12-20 21:43:44 UTC
Who is talking about border???? I am talking about windows with borders but without titlebars (see attached pictures).
Comment 8 qqqqqqqqq9 2010-12-20 21:47:41 UTC
Created attachment 55113 [details]
Shaded window without titlebar
Comment 9 Thomas Lübking 2010-12-20 21:49:41 UTC
ahhh, ok - you're talking about the "proprietary" rules of the oxygen decoration?!?

(kwin in general supports borders - it doesn't care about what the decoration plugin does/looks on them)
Comment 10 qqqqqqqqq9 2010-12-20 21:57:24 UTC
So this isn't the right place for this feature request? I sure like the feature to hide the title bar and would love to see those glitches be smoothed out. Wher sould i report it?
Comment 11 Thomas Lübking 2010-12-20 22:03:41 UTC
> Where sould i report it?

done. Sorry for the noise but we thought about an entirely different thing ;-)
Comment 12 Hugo Pereira Da Costa 2010-12-20 22:13:49 UTC
Will fix :) (but to-morrow)
Comment 13 qqqqqqqqq9 2010-12-20 23:06:56 UTC
@  Thomas Lübking
Thanks for fixing my typos ;)
@ Hugo Pereira Da Costa
Great :D. A similar problem arises with titlebar tabbing. When a window has more than one tab, automatically unhiding the titlebar seems to be a good idea, too.
Comment 14 Hugo Pereira Da Costa 2010-12-20 23:16:35 UTC
@qqqqqqq(etc)
Agreed. I figured the issue with tabbing also.
Actually I have the shading part fixed here (and I'm about to push to trunk)

However, the tabbing is more complicated, because unhiding/hiding the titlebar affects the layout metrics (Client::LayoutMetric), and the window layout is not reset properly when tabbing (so that the corresponding changes are not accounted for in the tabbed group).
Comment 15 Hugo Pereira Da Costa 2010-12-20 23:19:35 UTC
SVN commit 1208187 by hpereiradacosta:

Properly account for window's shaded state, and number of clients in groups when deciding whether or 
not the titlebar should be hidden. This is half the job, cause the above does not work (yet) when 
grouping windows among which one has hidden titlebar. Shading works well now, though.

CCBUG: 260815


 M  +1 -1      oxygenbutton.cpp  
 M  +7 -7      oxygenclient.cpp  
 M  +11 -1     oxygenclient.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1208187
Comment 16 Hugo Pereira Da Costa 2010-12-20 23:23:53 UTC
PS: interesting color style :)
Comment 17 qqqqqqqqq9 2011-01-02 18:09:22 UTC
Hi,
didn't have time to test it till now, but it works great. :D Very useful on small screens. Thanks a lot.
Comment 18 Hugo Pereira Da Costa 2011-04-02 10:43:14 UTC
renamed bug to reflect the "second" bug (grouping) that is still there.