Bug 258393 - activities manager shouldn't display "add widgets" option when widgets are locked
Summary: activities manager shouldn't display "add widgets" option when widgets are lo...
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: activities (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 16:48 UTC by disabled account
Modified: 2010-12-10 00:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of the button (23.03 KB, image/png)
2010-11-30 16:48 UTC, disabled account
Details

Note You need to log in before you can comment on or make changes to this bug.
Description disabled account 2010-11-30 16:48:17 UTC
Created attachment 53894 [details]
screenshot of the button

Version:           unspecified (using KDE 4.5.80) 
OS:                Linux

In the activities manager, even when widgets are locked, there is a button "add widgets" this button should not be there when widgets are locked, instead the button should say "unlock widgets" and when pressed, should transform into "add widgets".

The reason the button should not be there, is that due to the widgets being locked, it is impossible to add widgets, offering to add widgets and then not actually adding them is confusing behavior.

It would also restore consistency with the desktop, which doesnt display such an option when widgets are locked.

Reproducible: Always

Steps to Reproduce:
Make sure your widgets are locked!
Right click Desktop -> activities.
in the top right corner there is a button that says "add widgets".

Actual Results:  
In the top right corner there is a button that says "add widgets".

Expected Results:  
The button should say "unlock widgets".
Comment 1 Chani 2010-11-30 16:59:58 UTC
yes, you're right. it should.
Comment 2 Marco Martin 2010-12-09 22:44:28 UTC
SVN commit 1204973 by mart:

hide the add activity and add widget buttons when the corona gets locked
BUG:258393


 M  +16 -5     filterbar.cpp  
 M  +2 -0      filterbar.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1204973
Comment 3 Marco Martin 2010-12-10 00:22:52 UTC
SVN commit 1204997 by mart:

when the corona is locked, add an unlock button
CCBUG:258393


 M  +13 -1     filterbar.cpp  
 M  +1 -0      filterbar.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1204997