Created attachment 53341 [details] patch file to implement lock filter button Version: unspecified (using Devel) OS: Linux I wrote a quick add-on for the dolphin filter bar and if you like it and think it is useful and should be added to dolphin you can comment and "vote" for it (or if so be, you may criticize it). Basically it is a button which prevents the filter text from clearing when navigating to a different folder. Why this might be needed: This is an attempt to resolve the following usability conflict: -If one navigates to a different folder, the filter is automatically cleared since one does not want a situation where someone forgets a filter is applied and then doesn't understand why all the files within a folder are not appearing. versus: -A user might want to keep a filter while navigating an arbitrary set of folders, but is unable to, since the filter is automatically cleared upon navigation The implementation to try to resolve this conflict is as follows: 1. A lock filter toggle button is added to the right side of the filter bar. 2. If the lock filter button is clicked(on), then if the user navigates away from the current folder, the filter is not cleared. If the lock filter button is released(off), then the text is cleared on navigation...which is the current behavior. 3. A configurable shortcut is added to toggle the lock filter button, with the default being Ctrl-Shift-I (since the default shortcut for hiding and showing the filter bar is Ctrl-I.) 4. If the user toggles the lock filter button to released (off), then the text in the filter also clears. The assumption here is that if the user no longer wants the text to be locked, he probably also wants to clear the text. 5. When the filter bar is hidden, then the lock filter button is released. The next time the filter bar is shown, the lock filter button will be in the released(off) position and the filter text will have been cleared. 6. At application startup, the lock filter button is always off, and the filter bar text cleared. Patch file and partial screen shot are attached. Reproducible: Always Steps to Reproduce: Type in a filter. Navigate to different folder. Filter text, which on might want to keep, clears. Actual Results: See above Expected Results: See above
Created attachment 53342 [details] screenshot filter bar with lock button
Created attachment 53343 [details] screenshot filter bar with lock button
Sorry for the late response. It is better to use reviewboard.kde.org for submitting and sharing patch. Patches attached in bugzillla is easily to be flood by many other messages and forgotten.
Resetting assignee to default as per bug #305719
Please submit it to reviewboard :)
Git commit dfdb631b55c1f3c3c1527931f88254280a4d5045 by Frank Reininghaus, on behalf of Stuart Citrin. Committed on 22/05/2013 at 18:48. Pushed by freininghaus into branch 'master'. Filter bar: add a button that prevents clearing if the URL changes FIXED-IN: 4.11.0 REVIEW: 107392 M +2 -3 dolphin/src/dolphinviewcontainer.cpp M +32 -0 dolphin/src/filterbar/filterbar.cpp M +10 -0 dolphin/src/filterbar/filterbar.h http://commits.kde.org/kde-baseapps/dfdb631b55c1f3c3c1527931f88254280a4d5045