Bug 256475 - Folder View displays ugly (non-translucent) drag-and-drop picture
Summary: Folder View displays ugly (non-translucent) drag-and-drop picture
Status: RESOLVED UNMAINTAINED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-folderview (show other bugs)
Version: 4.8.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Ignat Semenov
URL:
Keywords:
: 280995 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-09 22:24 UTC by Mathias Panzenböck
Modified: 2018-09-04 19:11 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Hack for a nice translucent drag icon. (2.91 KB, patch)
2010-11-09 22:24 UTC, Mathias Panzenböck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Panzenböck 2010-11-09 22:24:05 UTC
Created attachment 53290 [details]
Hack for a nice translucent drag icon.

Version:           unspecified (using KDE 4.5.2) 
OS:                Linux

When dragging folder view items the D'n'D picture looks pretty ugly because it isn't translucent. This is the fault of Qt, because it doesn't setup the drag icon window appropriately. See Qt Bug 8519: http://bugreports.qt.nokia.com/browse/QTBUG-8519

I've written a hack in order to overcome this problem. This hack might be optimized a bit (remove the event filter earlier), but it basically works (I use it). See the attached patch.

Reproducible: Always

Steps to Reproduce:
Drag an item.

Actual Results:  
Ugly drag icon.

Expected Results:  
Nice translucent drag icon.
Comment 1 Mathias Panzenböck 2010-11-09 22:26:24 UTC
Forgot to say: The patch is against current KDE 4.5 SVN (revision 1194735).
Comment 2 Beat Wolf 2011-05-28 20:25:32 UTC
is this still a problem? What happend to this patch? Patches in bugzilla usually get lost. Can you submit it to https://git.reviewboard.kde.org ? thank you
Comment 3 Mathias Panzenböck 2011-05-28 23:01:28 UTC
Ok, I made a review request there:
https://git.reviewboard.kde.org/r/101463/
Comment 4 Ignat Semenov 2012-02-02 21:53:24 UTC
*** Bug 280995 has been marked as a duplicate of this bug. ***
Comment 5 Ignat Semenov 2012-03-02 10:05:03 UTC
OK guys time to recap on this one.

The relevant patch for Qt4 is in Gerrit now. But the Trolls want me to do a similar fix for Qt5, or they will not accept the Qt4 patch. Now the drag-and-drop functionality is broken in Qt5, as in, no pixmap is displayed at all on drag, so I can't even test the potential fix. So I've sent the patch to the top-secret kde-packagers mailing list, and it will be applied downstream on qt 4.8.1 release, middle-March IIRC.

http://codereview.qt-project.org/#change,16809 - those of you who have a Gerrit account (not many I reckon)

http://isemenov.blogspot.com/2012/02/folderview-fixes-part-i.html - same as what I've written above, at the end of the post.
Comment 6 Myriam Schweingruber 2012-05-17 19:21:21 UTC
(In reply to comment #5)
> OK guys time to recap on this one.
> 
> The relevant patch for Qt4 is in Gerrit now. But the Trolls want me to do a
> similar fix for Qt5, or they will not accept the Qt4 patch. Now the
> drag-and-drop functionality is broken in Qt5, as in, no pixmap is displayed
> at all on drag, so I can't even test the potential fix. So I've sent the
> patch to the top-secret kde-packagers mailing list, and it will be applied
> downstream on qt 4.8.1 release, middle-March IIRC.
> 
> http://codereview.qt-project.org/#change,16809 - those of you who have a
> Gerrit account (not many I reckon)
> 
> http://isemenov.blogspot.com/2012/02/folderview-fixes-part-i.html - same as
> what I've written above, at the end of the post.

Any news on this?
Comment 7 Ignat Semenov 2012-05-18 14:05:00 UTC
Yes, I need to write a patch for Qt5 in order for the 4.8 patch to be accepted (qt project policy). Last time I checked drag and drop was broken in qt5, which was a blocker. Once dnd is fixed in qt5, the road is open for both patches.
Comment 8 Andrew Crouthamel 2018-09-04 19:11:50 UTC
Hello! Plasma 4 was replaced by Plasma 5 four years ago by the KDE community. In that time we have made great strides in stability and functionality. We are closing all Plasma 4 bugs as most of them are no longer applicable to the new frameworks Plasma 5 is built upon. If you could, please re-test with the latest version of Plasma 5, and submit a new bug to "plasmashell" if you continue to have an issue. Thank you!