Bug 256160 - Filterline should focus upon activation
Summary: Filterline should focus upon activation
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 16:56 UTC by Pascal d'Hermilly
Modified: 2010-12-19 19:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal d'Hermilly 2010-11-05 16:56:01 UTC
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux

If you have used the filter line ealier and the focus is not in it anymore, when you activate it (ctrl+i) it should not disappear, but focus so you can search again..
The current behaviour differs from filter behaviour in any other programs I know. e.g. Konqueror and Kate.

Reproducible: Didn't try
Comment 1 Peter Penz 2010-11-05 17:05:27 UTC
Thanks for the report. Could you please provide the steps required to get a filter-bar without focus? I cannot reproduce the issue here, but probably I'm missing something...
Comment 2 Pascal d'Hermilly 2010-11-05 19:29:09 UTC
After using the filter bar, you click around and do stuff while the filter bar stays open in the bottom. I navigate mostly with the keyboard, so instead of moving the mouse to the already open filter-bar and clicking it to focus I would like to focus it by pressing the ctrl+i shortcut again. The actual behaviour is that the unfocused filter bar closes and I have to press the shortcut again to get a filter bar with focus.
Comment 3 Peter Penz 2010-11-07 15:39:30 UTC
OK, understood. Checked the behavior in Kate and I agree that this should be changed.
Comment 4 Peter Penz 2010-11-07 15:55:21 UTC
SVN commit 1193912 by ppenz:

Make the filter-behavior similar to applications like Kate, where activating the filter lets focus it again.

BUG: 256160
FIXED-IN: 4.6.0


 M  +4 -4      dolphinmainwindow.cpp  
 M  +1 -4      dolphinmainwindow.h  
 M  +1 -0      dolphinviewcontainer.cpp  
 M  +2 -0      dolphinviewcontainer.h  
 M  +1 -0      filterbar/filterbar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1193912
Comment 5 Pascal d'Hermilly 2010-11-08 00:03:41 UTC
cool :-)
Comment 6 Pascal d'Hermilly 2010-12-06 14:55:55 UTC
I just checked out the new behaviour which is definitely a big improvement. 
The only thing missing to make it behave like in Kate is that it should select the previously typed text such that if you type a new filter string it will overwrite the old filter string.
It there time to fit this in to 4.6?
Comment 7 Peter Penz 2010-12-06 15:20:33 UTC
Great that you like the new behavior :-) Selecting the previously typed text is useful I think and it should be no big deal to add this to 4.6

Please ping me again directly if I don't have fixed this within the next two weeks (you'll notice the fix if I've set you on CC of the patch).
Comment 8 Pascal d'Hermilly 2010-12-17 10:48:27 UTC
ping
Comment 9 Peter Penz 2010-12-17 11:07:35 UTC
Ah, good that you pinged me :-) Added to my TODO-list now, will try to fix it this weekend!
Comment 10 Peter Penz 2010-12-19 13:04:30 UTC
SVN commit 1207719 by ppenz:

Select the whole text in the filterbar and searchbox if the widget has lost the focus and gets focused again by the shortcut (this behavior is consistent to e.g. the behavior in Kate).

CCBUG: 256160


 M  +5 -0      dolphinviewcontainer.cpp  
 M  +6 -1      filterbar/filterbar.cpp  
 M  +7 -2      filterbar/filterbar.h  
 M  +6 -0      search/dolphinsearchbox.cpp  
 M  +5 -0      search/dolphinsearchbox.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1207719
Comment 11 Pascal d'Hermilly 2010-12-19 19:14:48 UTC
:-)