Bug 255898 - patch: taglib-extras needs to provide wcscasecmp for DragonFly, too
Summary: patch: taglib-extras needs to provide wcscasecmp for DragonFly, too
Status: RESOLVED FIXED
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Other
: NOR normal
Target Milestone: ---
Assignee: Jeff Mitchell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 17:44 UTC by Alex Hornung
Modified: 2010-12-14 16:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Hornung 2010-11-02 17:44:53 UTC 
Version:           unspecified (using Devel) 
OS:                other

taglib-extras build currently fails on DragonFly due to a missing symbol: wcscasecmp. The inlined patch below fixes the issue:


Index: taglib-extras/taglib-extras/tfile_helper.cpp
===================================================================
--- taglib-extras/taglib-extras/tfile_helper.cpp        (revision 1192036)
+++ taglib-extras/taglib-extras/tfile_helper.cpp        (working copy)
@@ -31,7 +31,7 @@
 #endif
 #include <wchar.h>
 
-#if defined(__APPLE__) || defined(__FreeBSD__) || defined(_WIN32) || defined(_WIN64) || defined(__sun)
+#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__DragonFly__) || defined(_WIN32) || defined(_WIN64) || defined(__sun)
 int wcscasecmp(const wchar_t *s1, const wchar_t *s2)
 {
      int i;


Reproducible: Always
Comment 1 Scott Wheeler 2010-11-02 18:36:12 UTC 
Reassigning to Jeff since this isn't about taglib proper.
Comment 2 Alex Hornung 2010-12-14 15:46:37 UTC 
Raphael, I hope you don't mind if I CC you for this. It's a trivial ifdef that needs to be added for this to work on DragonFly.

Regards,
Alex
Comment 3 Raphael Kubo da Costa 2010-12-14 16:32:57 UTC 
SVN commit 1206481 by rkcosta:

Add __DragonFly__ to the wcscasecmp #ifdef.

Fixes build on DragonFly BSD.

Original patch by Alex Hornung <alexh AT dragonflybsd DOT org>, thanks!
Ack-ed by Jeff Mitchell on IRC.

BUG: 255898



 M  +1 -1      tfile_helper.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1206481