Bug 254805 - Spell checker is buggy - make it better
Summary: Spell checker is buggy - make it better
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kspell (show other bugs)
Version: 4.5
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 23:33 UTC by Wojciech Ryrych
Modified: 2023-01-12 05:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Ryrych 2010-10-20 23:33:42 UTC
Version:           0.9.92 (1.0 Beta4) (using KDE 4.5.2) 
OS:                Linux

Let me guide you through the whole process.

First I set my dictionary:
http://wstaw.org/m/2010/10/20/spell01.png

Next I type in the incorrect word - aktually (should be actually). I'd like to mention that incorrect words are not always distinguished for the first time. On the contrary one have to disable spell checker and enable it again - please test it.
OK, but assume that the wrong typed word has been distinguished for the first time:
http://wstaw.org/m/2010/10/20/spell02.png

Now I press space and... the previously distinguished word is no longer underlined. Press space again and it is. Definitely bug - as a rule of thumb spell checkers underline a incorrect words especially after pressing space - it's very natural:
http://wstaw.org/m/2010/10/20/spell03_.png

And finally. OK the word is incorrect so let me correct it. Just Right Mouse Button on this word:
http://wstaw.org/m/2010/10/20/spell04.png

...oops! There're no suggestions! AFAIR they were in previous trunk version.

So make the spell checker rock the house! :D


Reproducible: Always




OS: Linux (i686) release 2.6.35-999-generic
Compiler: cc
Comment 1 Mehrdad Momeny 2010-10-21 21:20:51 UTC
SVN commit 1188245 by momeny:

BUG:254805 Using SIGNAL to add our action to textedit to keep spell checking context menu
This also depends Choqok to KDE 4.5 libs

 M  +1 -1      CMakeLists.txt  
 M  +4 -6      libchoqok/ui/choqoktextedit.cpp  
 M  +1 -1      libchoqok/ui/choqoktextedit.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1188245
Comment 2 Wojciech Ryrych 2010-10-22 20:35:38 UTC
OK, there are suggestions now but one problem remains. Please refer to:

> Now I press space and... the previously distinguished word is no longer 
> underlined. Press space again and it is. Definitely bug - as a rule of thumb
> spell checkers underline a incorrect words especially after pressing space - 
> it's very natural

Now incorrect, underlined word is no longer distinguished after pressing space after this word.
I would consider underlining incorrect words just after pressing space. I think it isn't a good idea to check if a word is correct while typing it. I mean, underline it after an end of the word:

for example:
1. aktua (word isn't complete, don't underline it)
2. aktually (word is finished but no space after it - no underline)
3. aktually_ (space - "_" - here). If word is incorrect - underline it
Comment 3 Wojciech Ryrych 2010-12-30 19:35:12 UTC
I've found some time to test spell checker in upcoming stable version of Choqok. And it still needs some love because it's a little flawed.
Let me describe the whole process in a list:

1. Restart of Choqok - "fresh" start
2. RMB > Auto Spell Check is checked
3. RMB > Set Spell check Language > English is checked
4. Typing a incorrect word "aktually"
5. The word is underlined as incorrect (true)
5a. RMB > suggestions are in Polish (system language), not in checked English
5b. Typing one space after word ("aktually ") - the word is no longer marked as incorrect but it should be
6. RMB > Set Spell check Language > tick off "English"
7. RMB > suggestions are now correctly in English even though the language is not ticked (no language is ticked)
8. Ticking on English again, the tick mark is not displayed

I think that's all.
Comment 4 Mark Fraser 2010-12-30 19:41:17 UTC
I can confirm this bug in version 0.9.93 with KDE 4.5.4 in Kubuntu 10.10.
Comment 5 Thomas Tanghus 2010-12-30 20:48:19 UTC
Confirmed on version 0.9.98 (1.0 RC1) using KDE Development Platform 4.5.90 (4.6 RC1)
Comment 6 Thomas Tanghus 2010-12-30 20:53:12 UTC
(In reply to comment #5)
> Confirmed on version 0.9.98 (1.0 RC1) using KDE Development Platform 4.5.90
> (4.6 RC1)

Now to get to select the language, you have to first select a different one, then the one I aktually ;) want. Otherwise it stays un-ticked.
Comment 7 Andrew Crouthamel 2018-11-05 03:10:49 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Andrew Crouthamel 2018-11-16 05:38:31 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 9 Justin Zobel 2022-12-13 02:54:00 UTC
Thank you for reporting this issue in KDE software. As it was reported on an older version, can we please ask you to see if you cazn reproduce the issue with a more recent software version?  
  
If you can confirm this issue still exists in a recent version, please change the version field and the status to "REPORTED" when replying. Thank you!
Comment 10 Bug Janitor Service 2022-12-28 05:25:48 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Bug Janitor Service 2023-01-12 05:18:41 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!