Bug 254600 - Konsole running irssi does not close properly
Summary: Konsole running irssi does not close properly
Status: RESOLVED DUPLICATE of bug 251566
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 2.4.2
Platform: Ubuntu Linux
: NOR crash
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 23:24 UTC by Mike Smith
Modified: 2011-10-03 04:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Smith 2010-10-18 23:24:56 UTC
Version:           2.4.2 (using KDE 4.4.2) 
OS:                Linux

A konsole with a custom profile using irssi as the shell does not close correctly, causing all other konsoles running to hang.

Reproducible: Always

Steps to Reproduce:
- Create a Konsole profile using /usr/bin/irssi as the command.
- Run konsole --profile IRC and close it.
- Observe hanging.
- alt-f2 killall -9 irssi (or alt-f2 killall -9 konsole) is the only way I've found to regain the ability to use Konsoles without logging out completely.

Actual Results:  
Any currently open Konsole instances hang, and it becomes impossible to open new ones as they also hang before even displaying a window.

Expected Results:  
Less hanging.

I am currently running Ubuntu amd64, but I have also observed this bug on an Arch Linux amd64 system with KDE 4.5.1.

The same effect can be caused by closing a Konsole using the default profile after running 'exec irssi' in it; maybe this is something related to not having a shell running in it?
Comment 1 Jekyll Wu 2011-08-02 04:24:17 UTC
I can reproduce this with konsole-2.7.999.

Konsole will hangs for a while (30s ~ 1min), then it will be reponsive again. But the irrsi tab(I have opened another shell tab ) is still open and running.

The root cause is irssi responds to SIGHUP in a special way[1]: instead of dying , it performs a /RELOAD. 

So this bug is actually the same as #251566. See its comment #4 .

[1] - http://cvs.silcnet.org/source/irssi/NEWS

*** This bug has been marked as a duplicate of bug 251566 ***
Comment 2 Jekyll Wu 2011-10-03 04:54:01 UTC
Git commit e3a09c9c4d7a35d458440e28501098f3ac13b684 by Jekyll Wu.
Committed on 03/10/2011 at 05:01.
Pushed by jekyllwu into branch 'master'.

Close session reliably when the session process doesn't die with SIGHUP.

BUG:241709
BUG:251566
CCBUG:254600
FIXED-IN: 4.8
REVIEW:102239

M  +1    -1    src/MainWindow.cpp
M  +41   -18   src/Session.cpp
M  +20   -5    src/Session.h
M  +41   -3    src/SessionController.cpp
M  +8    -2    src/SessionController.h
M  +2    -2    src/ViewManager.cpp

http://commits.kde.org/konsole/e3a09c9c4d7a35d458440e28501098f3ac13b684