Bug 252050 - Allow user to set custom icon
Summary: Allow user to set custom icon
Status: RESOLVED FIXED
Alias: None
Product: kdialog
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Brad Hards
URL:
Keywords:
: 395030 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-22 15:58 UTC by Kai Uwe Broulik
Modified: 2018-06-21 11:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.7.0


Attachments
Patch to enable --icon to affect passivepopup as well (1.58 KB, patch)
2011-05-03 12:14 UTC, Kai Uwe Broulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2010-09-22 15:58:31 UTC
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux

I really like using kdialog, as it looks so professional compared to stupid text-only scripts.
I can set the title of a notification but not its icon. It always has that info-symbol, especially gets annoying when I use --passivepopup.

(Also, is there a way of changing its category? kdialog notifications always pop up as “knotify” notifications in notification history. It‘d be nice to change it to something like “useful utility abc” then I know what application caused that notification)

Reproducible: Always
Comment 1 Kai Uwe Broulik 2010-09-22 16:09:52 UTC
Addition: The KDE option --icon does set an icon but only for the dialogs, notifications are untouched by that parameter.
Comment 2 Kai Uwe Broulik 2011-01-02 18:54:20 UTC
No change with the new notification system in 4.6 unfortunately. Now you have that big fat info-icon that spits in your face ;)
Comment 3 Kai Uwe Broulik 2011-05-03 12:14:53 UTC
Created attachment 59569 [details]
Patch to enable --icon to affect passivepopup as well

I just discovered notify-send works fine for notifications with icons but I definitly want that in kdialog as well.
So I looked at the code and found what was responsible and added something. I couldn’t compile it (have no real development environment or dependencies set up) and I don’t know if this is the correct approach but I would appreciate it if you have a look at it.
(I wanted to push it to reviewboard but the identity.kde.org activation mail somehow got lost or is not yet arrived or whatever, so I post it here, first)
Comment 4 Brad Hards 2011-05-03 22:53:03 UTC
I had a quick look at the patch (didn't try it), and it looks ok.

I'd encourage you to build / test it. There are instructions on community.kde.org and techbase.kde.org for how to set up a development environment.
Comment 5 Kai Uwe Broulik 2011-05-05 18:08:59 UTC
I just changed something since that --icon parameter doesn’t turned out correctly and so I added --passiveicon for the icon of passivepopup. I compiled it and it works as expected :) Yay! :D

It’s in the reviewboard:
https://git.reviewboard.kde.org/r/101282/
Comment 6 Christoph Feck 2011-05-10 12:45:19 UTC
Git commit 8953d76773a39a756513280a04409f8984840268 by Christoph Feck.
Committed on 10/05/2011 at 12:37.
Pushed by cfeck into branch 'master'.

Fix passive popup messages

* --icon argument did not work
* fallback to old style popups was broken because of a timer issue

Investigations and patch by Kai-Uwe Broulik, thanks!

REVIEW: 101282
Minor comment cleanup by me

FIXED-IN: 4.7.0
BUG: 252050

M  +45   -19   kdialog/kdialog.cpp     

http://commits.kde.org/kde-baseapps/8953d76773a39a756513280a04409f8984840268
Comment 7 Christoph Feck 2018-06-21 11:25:03 UTC
*** Bug 395030 has been marked as a duplicate of this bug. ***