Version: svn (using Devel) OS: Linux Since trunk kdelibs 1170981 all koffice application are completely untranslated. The fix for that issue (http://websvn.kde.org/?view=revision&sortby=date&revision=1175322) breaks lauching any koffice application e.g.: $ kword KGlobal::locale::Warning your global KLocale is being recreated with a valid main component instead of a fake component, this usually means you tried to call i18n related functions before your main component was created. You should not do that since it most likely will not work QMutex::lock: Deadlock detected in thread 140210151987072 See http://lists.kde.org/?l=kde-core-devel&m=128441883425910&w=2 Reproducible: Always
Is that a KOffice bug ? In any case, it can't be a release_blocker for 2.3, could be fixed in the following maintenance release, but is there a koffice developer with a kdelibs development ? Otherwise, it might be difficult to find where the problem is.
(In reply to comment #1) > Is that a KOffice bug ? Yes, see my report and read the links. > In any case, it can't be a release_blocker for 2.3... i18n is not just a nice addon for kde applications, it is a requirement. From my Pov this is defintely a release blocker.
I think, following David Faure's comments on irc, that this patch should fix the problem. 22:42:47 < dfaure> Mek: yeah and the ones in pigment are the cause for the KLocale warning on startup (with kdelibs trunk), because they call i18n before even entering main(0 22:42:51 < dfaure> *that* is a problem for sure 22:43:31 * dfaure means the static KoIDs in KoColorModelStandardIds 22:43:42 < dfaure> this should be turned into methods, I don't see another way 22:44:14 < Mek> yeah, methods or a singleton instance with those as member variables
Created attachment 53189 [details] make the colorspace id's methods There are no unittest regressions and krita still runs. I did not do a performance regression test.
*** Bug 254291 has been marked as a duplicate of this bug. ***
The code is for sure wrong and is what is causing the warning. But if the warning is showing it means it is hitting my code to fix broken code like yours so it should still be working. So there is two possibilities: * There is something even more broken in your apps * My workaround doesn't work as it should all the time. I'll try compiling koffice from trunk (i understand that this is where problem is) and see what i can do. Sincerely the hint at saying "who cares about having our apps untranslated, let's release anyway" makes me sad, please open your mind to the millions of people out there that don't understand english.
I have concern that using methods would have a significant impact on translation, instead we should delay the translation and add a constructor to KoID that takes a KLocalizedString, I will prepare a patch now. > Sincerely the hint at saying "who cares about having our apps untranslated, > let's release anyway" makes me sad, please open your mind to the millions of > people out there that don't understand english. Huh who said that ? The original reporter didn't mention that translation was broken with *current* stable kdelibs. But with "trunk kdelibs 1170981", which as you may know is not released, and I mentioned that the bug would have to fix in the first maintenance release of koffice that would happen *before* the next release of kdelibs. So before of accusing people of not caring (especially to someone who spend quiet a lot of time on translations topic related to koffice) about untranslated apps I suggest you get all the facts together, thank you.
Created attachment 53194 [details] delay the translation of names
Much nicer than my patch -- I can't test it here, but following the apidox it should work. As far as I'm concerned, I would like to have this in trunk.
Created attachment 53234 [details] Updated version of delayed-ids Patch, build fixes This new version just fixes some build issues (const correctness clashes) with the latest SVN trunk.
SVN commit 1194087 by berger: (possible) Fix: strings shown untranslated in the user interface CCBUG:251606 M +24 -1 interfaces/KoID.h M +12 -12 libs/pigment/KoColorModelStandardIds.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1194087
I have now commited what I think should fix the issue. If it does not feel free to reopen.
With KOffice r1194089 I am now able to start karbon, kexi, kivio, kplato, kpresenter, kspread, kword in locale != en_US. But for krita this still fails with this output in kosole: $ KDE_LANG=x-test krita KGlobal::locale::Warning your global KLocale is being recreated with a valid main component instead of a fake component, this usually means you tried to call i18n related functions before your main component was created. You should not do that since it most likely will not work QMutex::lock: Deadlock detected in thread 140080133412832
I guess that means we have some more static translated strings somewhere in Krita.
And it's a krita bug now
SVN commit 1194149 by berger: Fix: more static object should not try to make a translation CCBUG: 251606 M +2 -2 image/kis_base_mask_generator.h M +2 -2 image/kis_bookmarked_configuration_manager.cc M +10 -10 plugins/paintops/libpaintop/kis_dynamic_sensor.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1194149
I hope I got all of them now :)
(In reply to comment #17) > I hope I got all of them now :) Apparently yes, krita starts now in locale != en_US :) Thanks.
commit 84164d2080454961bd83aeed63f1779d70b1edac branch words-change_tracking-ganeshp Merge: 5d79bdb d9e8624 Author: Ganesh Paramasivam <ganesh@crystalfab.com> Date: Fri Nov 12 04:31:30 2010 +0000 Merged revisions 1194087,1194095,1194149,1194209,1194219,1194245-1194246,1194249,1194251,1194267,1194290,1194297,1194304,1194486,1194510,1194522-1194523,1194529-1194530,1194534,1194562,1194632,1194647,1194662,1194700,1194732,1194751,1194763,1194766,1194775,1194782,1194811,1194947,1195025,1195082,1195092,1195096,1195103,1195105-1195108,1195116,1195191,1195202,1195246,1195305,1195327,1195362,1195379,1195409,1195450,1195466-1195467,1195484,1195494,1195518,1195526-1195527,1195531,1195539,1195553,1195559,1195566,1195585,1195597,1195620,1195758 via svnmerge from svn+ssh://ganeshp@svn.kde.org/home/kde/trunk/koffice ........ r1194087 | berger | 2010-11-08 13:35:22 +0530 (Mon, 08 Nov 2010) | 5 lines (possible) Fix: strings shown untranslated in the user interface CCBUG:251606 ........ r1194095 | zander | 2010-11-08 14:38:27 +0530 (Mon, 08 Nov 2010) | 3 lines Add files I forgot yesterday. Sorry about that... ........ r1194149 | berger | 2010-11-08 15:05:39 +0530 (Mon, 08 Nov 2010) | 4 lines Fix: more static object should not try to make a translation CCBUG: 251606 ........ r1194209 | scripty | 2010-11-08 15:37:35 +0530 (Mon, 08 Nov 2010) | 1 line SVN_SILENT made messages (.desktop file) ........ r1194219 | rempt | 2010-11-08 16:03:37 +0530 (Mon, 08 Nov 2010) | 1 line Do not compile krita if we have no lcms at all. ........ r1194245 | danders | 2010-11-08 18:19:48 +0530 (Mon, 08 Nov 2010) | 2 lines Duration spinbox: Limit unit to min/max also when entering from keyboard. ........ r1194246 | danders | 2010-11-08 18:23:17 +0530 (Mon, 08 Nov 2010) | 3 lines Fix rounding problem when scaling estimates. Use the configured min/max duration units in the used effort editor. ........ r1194249 | lassin | 2010-11-08 18:27:30 +0530 (Mon, 08 Nov 2010) | 2 lines Fixed pptx text shrinking so that value can be received also from masterslide. ........ r1194251 | rempt | 2010-11-08 18:39:01 +0530 (Mon, 08 Nov 2010) | 1 line LCMS 2 is new enough as well. ........ r1194267 | lassin | 2010-11-08 19:44:12 +0530 (Mon, 08 Nov 2010) | 2 lines Fixed bullet character of drawingML to be empty when not specified. ........ r1194290 | rempt | 2010-11-08 20:49:36 +0530 (Mon, 08 Nov 2010) | 1 line proper fix for warning ........ r1194297 | jsimon | 2010-11-08 21:05:22 +0530 (Mon, 08 Nov 2010) | 1 line Follow-up to boud's warning fixes ........ r1194304 | cfeck | 2010-11-08 21:52:11 +0530 (Mon, 08 Nov 2010) | 2 lines SVN_SILENT return ........ r1194486 | zachmann | 2010-11-09 10:08:28 +0530 (Tue, 09 Nov 2010) | 8 lines Honor plugin configuration Pass the configuration to the plugin loader so it is honored. Don't load kpresenter plugins in other apps BUG: 251970 BUG: 251973 ........ r1194510 | dkazakov | 2010-11-09 13:31:56 +0530 (Tue, 09 Nov 2010) | 5 lines Make a test in KisLayerTest faster 90s for a single test is too much for regular unit-testing. When something happens you can always test this case more thoroughtly. ........ r1194522 | mkruisselbrink | 2010-11-09 14:31:43 +0530 (Tue, 09 Nov 2010) | 1 line don't crash if the xls document contains more rows that kspread supports (should not be a problem in koffice-essen anyway) ........ r1194523 | mkruisselbrink | 2010-11-09 14:31:45 +0530 (Tue, 09 Nov 2010) | 1 line it seems this assert is meant to always fail, so make it so ........ r1194529 | danders | 2010-11-09 15:17:30 +0530 (Tue, 09 Nov 2010) | 2 lines SVN_SILENT explicit ........ r1194530 | danders | 2010-11-09 15:18:35 +0530 (Tue, 09 Nov 2010) | 2 lines Add some estimate scaling tests. ........ r1194534 | danders | 2010-11-09 15:19:42 +0530 (Tue, 09 Nov 2010) | 2 lines Fix bug in schedule distribution xml save/load. ........ r1194562 | dkazakov | 2010-11-09 16:12:02 +0530 (Tue, 09 Nov 2010) | 9 lines Added a real unittest for KisConvolutionPainter This test checks the correctness of the convolution algorithm by its (convolution) definition. Results: KisConvolutionWorkerFFT works fine KisConvolutionWorkerSpatial does not work fine =) ........ r1194632 | lassin | 2010-11-09 16:39:03 +0530 (Tue, 09 Nov 2010) | 2 lines Fixed some autoFit bugs in pptx filter. ........ r1194647 | scripty | 2010-11-09 16:54:58 +0530 (Tue, 09 Nov 2010) | 1 line SVN_SILENT made messages (.desktop file) ........ r1194662 | mlaurent | 2010-11-09 17:59:16 +0530 (Tue, 09 Nov 2010) | 2 lines Fix mem leak ........ r1194700 | breitmeyer | 2010-11-09 20:13:22 +0530 (Tue, 09 Nov 2010) | 4 lines fixed a crash, caused by an incomplete shapeProperty parsing this is only a temporary fix, a complete revisit of shape property parsing would be wise and will happen soon ........ r1194732 | vandenoever | 2010-11-09 23:03:11 +0530 (Tue, 09 Nov 2010) | 1 line Use jing.jar if it can be found and add Relax NG for ODF 1.0 and 1.1. ........ r1194751 | dkazakov | 2010-11-10 01:19:03 +0530 (Wed, 10 Nov 2010) | 5 lines Fix spatial convolution filter Rounding for integers should have been done on a level of KisMathToolbox. ........ r1194763 | berger | 2010-11-10 01:43:22 +0530 (Wed, 10 Nov 2010) | 4 lines Fix: crash when switching to the tool paint after using space and being locked into the pan tool CCBUG: 256415 ........ r1194766 | berger | 2010-11-10 02:01:46 +0530 (Wed, 10 Nov 2010) | 5 lines Fix: crash when replaying a macro with a filter BUG:256254 ........ r1194775 | langkamp | 2010-11-10 02:34:43 +0530 (Wed, 10 Nov 2010) | 1 line fix crash on saving image to kostore ........ r1194782 | berger | 2010-11-10 03:04:53 +0530 (Wed, 10 Nov 2010) | 2 lines add a script to set/get the settings from a kpp ........ r1194811 | staniek | 2010-11-10 04:19:07 +0530 (Wed, 10 Nov 2010) | 1 line fix empty icon ........ r1194947 | lassin | 2010-11-10 14:21:39 +0530 (Wed, 10 Nov 2010) | 2 lines Fixed ole replacement pictures in xlsx files to have more sensible position & size. ........ r1195025 | ingwa | 2010-11-10 15:22:30 +0530 (Wed, 10 Nov 2010) | 5 lines * Handle negative window widths * Fix a bug in world transform calculation when there was only a window defined and no viewport. ........ r1195082 | scripty | 2010-11-10 15:43:39 +0530 (Wed, 10 Nov 2010) | 1 line SVN_SILENT made messages (.desktop file) ........ r1195092 | breitmeyer | 2010-11-10 16:03:06 +0530 (Wed, 10 Nov 2010) | 4 lines Added series line and color handling to ms2003 filters and make some small adjustments to the Charting classes and made sure the 2007 filter uses them correctly too ........ r1195096 | vandenoever | 2010-11-10 16:26:28 +0530 (Wed, 10 Nov 2010) | 1 line Add a version of the ODF 1.2 Relax NG that allows for koffice specific extensions. The validation code has been adapted to use the extended schema. ........ r1195103 | mkruisselbrink | 2010-11-10 17:10:54 +0530 (Wed, 10 Nov 2010) | 1 line replcae kdbgstream with QDebug to compile with no deprecated code in kdelibs ........ r1195105 | mkruisselbrink | 2010-11-10 17:11:07 +0530 (Wed, 10 Nov 2010) | 1 line kotext doesn't use anything from libkutils, so don't link to it ........ r1195106 | mkruisselbrink | 2010-11-10 17:11:09 +0530 (Wed, 10 Nov 2010) | 1 line don't use deprecated kdelibs api's ........ r1195107 | mkruisselbrink | 2010-11-10 17:11:10 +0530 (Wed, 10 Nov 2010) | 1 line deprecated-- ........ r1195108 | mkruisselbrink | 2010-11-10 17:11:12 +0530 (Wed, 10 Nov 2010) | 1 line deprecated-- ........ r1195116 | rempt | 2010-11-10 17:43:27 +0530 (Wed, 10 Nov 2010) | 1 line Krita actually doesn't use qimageblitz anymore. ........ r1195191 | lassin | 2010-11-10 20:29:10 +0530 (Wed, 10 Nov 2010) | 2 lines Fixed pptx ole replacement pictures to work in more cases. ........ r1195202 | lassin | 2010-11-10 20:53:51 +0530 (Wed, 10 Nov 2010) | 2 lines Improved pptx graphicFrame styling. ........ r1195246 | ingwa | 2010-11-10 22:18:29 +0530 (Wed, 10 Nov 2010) | 4 lines * Fix a wrong if statement * Make a correct world transformation when there is no viewport defined. ........ r1195305 | langkamp | 2010-11-11 01:14:19 +0530 (Thu, 11 Nov 2010) | 1 line put koffice:anchor-type into common-text-anchor-attlist to cover more cases ........ r1195327 | langkamp | 2010-11-11 02:25:27 +0530 (Thu, 11 Nov 2010) | 1 line fix mirror attribute ........ r1195362 | langkamp | 2010-11-11 03:54:42 +0530 (Thu, 11 Nov 2010) | 1 line add koffice:nodeTypes attribute ........ r1195379 | langkamp | 2010-11-11 04:41:55 +0530 (Thu, 11 Nov 2010) | 2 lines fix saving on text:note, content has to be enclosed by a text:note-body ........ r1195409 | langkamp | 2010-11-11 05:36:15 +0530 (Thu, 11 Nov 2010) | 1 line reverse the order of saving text on shape and enhanced geometry, needed to validate ........ r1195450 | zachmann | 2010-11-11 11:15:32 +0530 (Thu, 11 Nov 2010) | 10 lines Fix: Bug 255993 - Crash loading file due to RDF code The problem is that the rdfData is not set when loading the header. Set the rdf data when loading the header and also add a test that if rdfData is there, if not return. BUG: 255993 ........ r1195466 | lassin | 2010-11-11 14:27:55 +0530 (Thu, 11 Nov 2010) | 2 lines Fixed xlsx drawing frames to have unit. ........ r1195467 | lassin | 2010-11-11 14:32:19 +0530 (Thu, 11 Nov 2010) | 2 lines Added minor fix to the previous xlsx drawing fix. ........ r1195484 | breitmeyer | 2010-11-11 15:33:55 +0530 (Thu, 11 Nov 2010) | 2 lines fixed line and marker handling in 2003 filters, and the color handling ........ r1195494 | boemann | 2010-11-11 15:52:28 +0530 (Thu, 11 Nov 2010) | 2 lines fix compile ........ r1195518 | rempt | 2010-11-11 17:33:01 +0530 (Thu, 11 Nov 2010) | 1 line really remove qimagblitz dependency, it wasn't used but still referenced ........ r1195526 | rempt | 2010-11-11 18:28:28 +0530 (Thu, 11 Nov 2010) | 1 line unused parameter ........ r1195527 | rempt | 2010-11-11 18:28:31 +0530 (Thu, 11 Nov 2010) | 4 lines Use the image file suffix instead of 0 If we pass 0, Qt tries to determine the type of the image file by checking the contents. For some image files, that breaks, notably eps. ........ r1195531 | vandenoever | 2010-11-11 18:32:25 +0530 (Thu, 11 Nov 2010) | 1 line Filter out false positives reported by libxml2. ........ r1195539 | vandenoever | 2010-11-11 18:44:16 +0530 (Thu, 11 Nov 2010) | 1 line Make check more robust against unexcpected types. ........ r1195553 | vandenoever | 2010-11-11 19:21:19 +0530 (Thu, 11 Nov 2010) | 1 line Add Fedore specific locations for OOoSDK. ........ r1195559 | vandenoever | 2010-11-11 19:37:43 +0530 (Thu, 11 Nov 2010) | 1 line Do a proper string search. ........ r1195566 | vandenoever | 2010-11-11 19:49:09 +0530 (Thu, 11 Nov 2010) | 1 line Fix build of slidecompare on Fedora. ........ r1195585 | breitmeyer | 2010-11-11 20:35:45 +0530 (Thu, 11 Nov 2010) | 5 lines added support for fills, background fills will come later, as well as the problematic data saved by ms2007, they seem to place xml blobs in some places of the xls documents, very weird ........ r1195597 | lassin | 2010-11-11 20:52:19 +0530 (Thu, 11 Nov 2010) | 2 lines Fixed a bug where pptx slideLayout would ignore its placement. ........ r1195620 | breitmeyer | 2010-11-11 21:48:39 +0530 (Thu, 11 Nov 2010) | 3 lines reverted 1194700 it created more crashes than it fixed, a real fix is in work ........ r1195758 | berger | 2010-11-12 04:32:29 +0530 (Fri, 12 Nov 2010) | 4 lines Compute preview of filters in threads. This fix UI blocking issues. BUG: 243691 ........ svn path=/branches/work/koffice-change-tracking/; revision=1195842