Bug 251157 - Show/Hide menu bar.
Summary: Show/Hide menu bar.
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 2.3
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 23:13 UTC by Fest
Modified: 2011-05-14 16:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fest 2010-09-13 23:13:59 UTC
Version:           2.3 (using KDE 4.5.1) 
OS:                Linux

Almost all KDE4 application have option to hide main menu bar by ctrl+m shortcut (and option in menu itself). 
It's really nice feature in few cases:
1) getting more space to main window.
2) getting rid of non-needed menu. (when you customized program look for youself and added all options you need to panel)
3) program looks better (imho)

Reproducible: Didn't try
Comment 1 Robby Stephenson 2010-09-20 00:10:42 UTC
(In reply to comment #0)
> Almost all KDE4 application have option to hide main menu bar by ctrl+m
> shortcut (and option in menu itself). 

Can you help convince me? I don't know if it's as common as you think.

Kate: no
Konqueror: no
Kmail: no
Choqok: no
Amarok: no
Skrooge: no
KWord: no

Dolphin: yes
Konsole: yes
Digikam: yes
Akregator: yes
KOrganizer: yes

(Those are just the ones I had running already or had installed to test)

Tellico's Settings menu is rather full as it is. I've considered removing menu options from there in the past because it looks too complicated. Adding another command there would be making things even more full. :)

And I'm not sure how useful Tellico is when the menu bar is hidden, there are many commands in there that are not in the toolbar or context menu...
Comment 2 Fest 2010-09-21 23:24:26 UTC
I though that programs, that still don't have hidden menu - just still didn't implemented that function.

Use case of main menu:
1) When you just started to use program (before you customized toolbar with buttons you use often)
2)When you have need to use rare command. (you didn't put it to toolbar, cause you mostly don't need it) 

So hidden main menu:
1) clear unneeded space (you mostly use toolbar) 
2) bigger useful space (main window)
3) and for my opinion looks better (especially if you use icon view mode)
4) no need to remove complicated options - just hide main menu bar. 

By the way:
Konqueror 4.5.1 : yes.
Comment 3 Fest 2010-12-12 02:24:59 UTC
In Amarok 2.3.90 this option is implemented.

So it's seem i was right. Programs that still don't have hidden menu option - just still didn't implemented that.
Comment 4 PC LX 2011-05-12 03:43:59 UTC
I have written two patches, the first to show/hide the menu and the second to switch the window to/from full screen. I have submitted these patches for review. 

When the user just wants to browse a catalog in search of something (to see, read, listen, whatever) the menu is of little use and switching the window to full screen makes good use all the screen space.

On my work station with two 21" HD screens the usability gain is small (if any) but on my 10" Eee netbook the improved use of screen space makes a big difference that far compensates the extra complexity of two more entries in the Settings menu (me think :) ).
Comment 5 Robby Stephenson 2011-05-13 16:10:41 UTC
(In reply to comment #4)
> I have written two patches, the first to show/hide the menu and the second to
> switch the window to/from full screen. I have submitted these patches for
> review. 
> 
> When the user just wants to browse a catalog in search of something (to see,
> read, listen, whatever) the menu is of little use and switching the window to
> full screen makes good use all the screen space.
> 
> On my work station with two 21" HD screens the usability gain is small (if any)
> but on my 10" Eee netbook the improved use of screen space makes a big
> difference that far compensates the extra complexity of two more entries in the
> Settings menu (me think :) ).

I understand your thoughts on that, but I respectfully disagree. I do not like this menu (even before you added the two additional items). :/
http://imageshack.us/m/200/1589/menumz.png

I haven't poked at it enough to say how to do it, but perhaps you can add the command and shortcut key, but not have them in the menu. That way, you and the bug reporter can have your "Hide menubar" and "Full Screen" capability, without cluttering up the menu?
Comment 6 Robby Stephenson 2011-05-14 16:50:38 UTC
Git commit 3fdc9939aa63218fe68350547b3ba0744715ce9a by Robby Stephenson.
Committed on 14/05/2011 at 16:48.
Pushed by rstephenson into branch 'master'.

Add shortcuts for fullscreen and showing/hiding menu bar

Note the shortcut key for the Internet search changed to Ctrl+I
since the default menubar shortcut is Ctrl+M.

Patch from Pedro Miguel Carvalho

BUG: 251157

M  +13   -8    ChangeLog     
M  +22   -1    src/mainwindow.cpp     
M  +8    -0    src/mainwindow.h     

http://commits.kde.org/tellico/3fdc9939aa63218fe68350547b3ba0744715ce9a