Version: 2.4.3 (using KDE 4.4.2) OS: Linux In kde 3.5 konsole had a "print screen" function this is absent in this version and it was incredibly useful Reproducible: Always Steps to Reproduce: run konsole - the print function is absent Actual Results: the print function is absent Expected Results: The print function should be implemented OS: Linux (x86_64) release 2.6.34-12-desktop Compiler: gcc I would say this was a feature request but it is hardly an enhancement because it was present in a previous version!
*** This bug has been confirmed by popular vote. ***
Well, even though it is a regression when compared with then KDE3 konsole, reimplementing it will definitely introduce new UI and strings. So it is a new feature from the POV of release management. Side note: I almost never use any printing functionality, so clearly it is unlikely for me to look into this feature in the near future.
Created attachment 73034 [details] Implements "Print screen" functionality as known from KDE 3.5 I have implemented the requested print screen functionality with this patch. It is a bit of a hack, but so was the implementation in KDE 3.5, so I do not feel too guilty about it. :-) There are some considerations concerning what would be the most useful way to have this functionality, but I'm quite sure it is pretty close to the way it worked in KDE 3.5 and of course I hope someone would like to test it and provide feedback if there's something that should be changed. So please test and comment. /Kasper
Thanks for the patch. 1. remember to increase the sessionui.rc version when changing that file. 2. for my testing w/ the pdf output, it is cutting off the right side characters (3-6). I think it is due to the fonts. 3. Konsole doesn't use Ctrl+<key> so that the terminal can use it. So we can use Ctrl+Shift+P
Created attachment 73564 [details] print_screen.patch Hello Kurt, On 08/10/2012 02:41 PM, Kurt V. Hindenburg wrote: > 1. remember to increase the sessionui.rc version when changing that file. OK. I'll remember that. > 2. for my testing w/ the pdf output, it is cutting off the right side > characters (3-6). I think it is due to the fonts. I do not think it's a font issue. I think it might be because I don't do any scaling and the paint device used to paint the console on screen is often larger than on paper. I tough about having a "scale ouput" option in the print dialog and having it selected by default (since that is probably what most users want). What do you think about that solution? > 3. Konsole doesn't use Ctrl+<key> so that the terminal can use it. So we can > use Ctrl+Shift+P > OK, hadn't thought of that but that makes sense. I'll change that. Cheers, Kasper
Hi again Kurt, I have implemented the features the way I told you in our previous communication. So: - I have increased the version number konsole.kcfg - Ctrl-Shift-P is now used as a shortcut for printing - The ouput is now scaled to fit the size of the paper being printed on, with the scaling being an option defaulting to true. Please let me know what you think. Cheers, /Kasper
The testing looks good - I'll look at the code and commit it for 4.10 Thanks
Git commit 5526c75fb26c6967937699601abc31457b338712 by Kurt Hindenburg. Committed on 03/09/2012 at 18:26. Pushed by hindenburg into branch 'master'. Reimplement KDE3's print screen functionality Add File->Print Screen menu option Patch by Kasper Laudrup laudrup@stacktrace.dk FIXED-IN: 4.10 M +3 -1 desktop/sessionui.rc M +2 -0 src/CMakeLists.txt A +48 -0 src/PrintOptions.cpp [License: GPL (v2/3)] A +43 -0 src/PrintOptions.h [License: GPL (v2/3)] A +57 -0 src/PrintOptions.ui M +37 -0 src/SessionController.cpp M +1 -0 src/SessionController.h M +56 -6 src/TerminalDisplay.cpp M +17 -3 src/TerminalDisplay.h M +10 -0 src/settings/konsole.kcfg http://commits.kde.org/konsole/5526c75fb26c6967937699601abc31457b338712
Fantastic - I look forward to this making its way to my distro! Thanks!
*** Bug 326857 has been marked as a duplicate of this bug. ***