Created attachment 50108 [details] patch to kdebase-workspace Version: 4.4 (using KDE 4.4.5) OS: other Attached is a patch that fixes ksysguard for DragonFly by checking the correct status fields for the process and lwp. Reproducible: Always
Please don't commit this yet; I'm reworking it so that dragonfly has its own processes_foo file.
Created attachment 54587 [details] patch for ksysguard to build on DragonFly Ok, I have a proper solution now, separating the dragonfly implementation from the FreeBSD implementation. Please review and commit, if appropriate :) Regards, Alex
Created attachment 54588 [details] patch for ksysguard to build on DragonFly Ok, I have a proper solution now, separating the dragonfly implementation from the FreeBSD implementation. Please review and commit, if appropriate :) Regards, Alex
Just wanted to comment that this compiles for me on DragonFly 2.9.
Sounds good - feel free to commit if you are able to, or ask someone else to commit please. It's signed off by me.
I can apply the patch, however there's this bit in it about which I'd like some clarification: in processes_freebsd_p.cpp's readProcStat() this call was left ps->setSysTime(0); which was not called in the FreeBSD code path before. Was it intentional or can it be removed too?
That was indeed accidental and is incorrect. Thanks for spotting it. If required, I can submit a new patch with that line removed, too. Regards, Alex
SVN commit 1213285 by rkcosta: Add a process file for DragonFly BSD. It should fix compilation on it, as well as provide meaningful stats for it on ksysguard. Original patch by Alex Hornung <alexh AT dragonflybsd DOT org> with some minor style cleanups, thanks a lot! BUG: 247614 A processes_dragonfly_p.cpp [License: LGPL (v2+)] M +2 -48 processes_freebsd_p.cpp M +3 -1 processes_local_p.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1213285
SVN commit 1213286 by rkcosta: Backport r1213285. Add a process file for DragonFly BSD. It should fix compilation on it, as well as provide meaningful stats for it on ksysguard. Original patch by Alex Hornung <alexh AT dragonflybsd DOT org> with some minor style cleanups, thanks a lot! FIXED-IN: 4.6.0 CCBUG: 247614 A processes_dragonfly_p.cpp [License: LGPL (v2+)] M +2 -48 processes_freebsd_p.cpp M +3 -1 processes_local_p.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1213286