Version: 1.13.5 (using KDE 4.4.5) OS: Linux When I compose a mail and want to change the spellchecker language, I invoke the Settings->Spellchecker dialogue. The first combobox contains a list of languages. When I change them in the dialogue, the composer window adapts automatically. However, when I click on the Cancel button, the last selected language remains active. Instead, it should switch back to what was the active language before invoking the dialogue to be consistent with the user's expectation regarding Cancel. Reproducible: Always Steps to Reproduce: Install two aspell catalogues, invoke dialogue, switch language, press Cancel, invoke dialogue again. OS: Linux (x86_64) release 2.6.32-3-amd64 Compiler: cc
The same issue happens btw. with the actual spellchecker from Extras->Spelling. Regarding the usability, the dialogue caption should probably also change from "Sonnet setup" to "Spellchecking setup".
SVN commit 1162582 by mlaurent: It's right it's better to use "SpellChecking" here not sonnet CCBUG: 247338 M +1 -1 configdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1162582
Confirmed with kmail 1.13.5/KDE 4.4.5. The dialog is even more inconsistent. Changes in the drop down are applied on the fly, this means the both 'Apply' and the 'Cancel' are useless. So there are two options: 1. Apply changes on the fly and only have the OK button 2. Apply changes only when 'Apply' or 'OK' is clicked, the latter would close the dialog, the first not. Clicking 'Cancel' should close the dialog without any changes. I suggest two use option 2 since it is more KDE'ish.
Valid in master with the mentioned steps: - Settings / spellchecker, change the language / hit cancel - Settings / spellchecker -> The language wasn't reset
I confirm it. Will look at it
Git commit b138c271eff95afb51d35ecb8e77e14c94822ad1 by Montel Laurent. Committed on 27/02/2012 at 11:40. Pushed by mlaurent into branch 'KDE/4.8'. Fix Bug 247338 - Sonnet spellchecking dialogue: Cancel action not implemented properly signal languageChanged was emitted all the time when a config was changed in widget. So it was not as defined in api. Created a new signal configChanged() better name and keep old signal. Remove it for KDE5 and clean up this class (We need to make some work on sonnet for kde 5) FIXED-IN: 4.8.1 M +8 -0 kdeui/sonnet/configdialog.cpp M +14 -3 kdeui/sonnet/configdialog.h M +3 -3 kdeui/widgets/ktextedit.cpp http://commits.kde.org/kdelibs/b138c271eff95afb51d35ecb8e77e14c94822ad1