Bug 247151 - JJ: Group digits also in "n base" mode (hex, bin)
Summary: JJ: Group digits also in "n base" mode (hex, bin)
Status: RESOLVED FIXED
Alias: None
Product: kcalc
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Klaus Niederkrüger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 16:40 UTC by Christoph Feck
Modified: 2013-02-18 23:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.10.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2010-08-09 16:40:53 UTC
Version:           unspecified (using Devel) 
OS:                Linux

KCalc has a feature to group digits by thousands (3 digits). It would be nice to also group binary or hexadecimal digits, probably best to use 4 digits (maybe 8 for binary).

Reproducible: Didn't try
Comment 1 Michael Skiba 2012-07-02 19:12:00 UTC
Yeah, since the grouping is an optional function that can be disabled I think it's a nice idea. I'll write a patch to add that functionality.

For the records: The position of the decimal separator is determined by the active locale. I don't think there are any standards for the position of the binary/hex separator, so I'll set a fixed position of 8 (binary) or 4 (hex). Maybe we should make that an option in the settings on the other hand how many people would use that?
Comment 2 Michael Skiba 2012-07-03 21:19:24 UTC
I've committed the patch to the kde reviewboard, where it currently awaits review & approval: https://git.reviewboard.kde.org/r/105427/
Comment 3 Evan Teran 2013-02-10 13:53:38 UTC
patch applied to master branch, once I clean up some things, I'll merge the change with the 4.10 branch so it'll make the  next 4.10 release.
Comment 4 Christoph Feck 2013-02-11 01:03:51 UTC
The patch introduces new strings, so don't apply to 4.10, unless you asked the i18n people.
Comment 5 Evan Teran 2013-02-11 17:52:16 UTC
Hmm, that's a good point. Unfortunately I did already apply the changes to 4.10. How should I contact the i18n people about getting translations in the works?
Comment 6 Christoph Feck 2013-02-11 18:26:24 UTC
Their list is at https://mail.kde.org/mailman/listinfo/kde-i18n-doc

For more information, see http://i18n.kde.org/
Comment 7 Christoph Feck 2013-02-11 20:40:03 UTC
Thanks Michael, just compiled it, it's really helping me.
Comment 8 Michael Skiba 2013-02-12 12:03:45 UTC
Glad to hear that, it's my first real patch for a kde app :-)

Thanks to Albert and Evan for taking care of it.