Bug 245618 - error messages in status-panel should be displayed in a full row
Summary: error messages in status-panel should be displayed in a full row
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Unlisted Binaries Linux
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-24 10:18 UTC by H.H.
Modified: 2012-04-13 07:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.0
Sentry Crash Report:


Attachments
and this is not a very long error message.. (9.79 KB, image/jpeg)
2010-07-24 10:18 UTC, H.H.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description H.H. 2010-07-24 10:18:33 UTC
Created attachment 49451 [details]
and this is not a very long error message..

Version:           unspecified (using KDE 4.4.92) 
OS:                Linux

to understand what I mean, please have a look at attached screenshot

Reproducible: Didn't try




OS: Linux (x86_64) release 2.6.34-12-desktop
Compiler: gcc
Comment 1 FiNeX 2010-08-02 14:03:48 UTC
Please, would you like to explain the steps to reproduce the bug?


Thanks!!!
Comment 2 H.H. 2010-08-02 22:43:16 UTC
I don't remember how I did that. But _any_ error-message in dolphin is displayed like you see in the screenshot. I think this is a problem with the layout-code, in case you have the status-bar-layout configured like me.
Comment 3 Peter Penz 2012-04-12 22:11:59 UTC
Git commit 213450d39704fc0154da5f0e45e4198af8239842 by Peter Penz.
Committed on 12/04/2012 at 23:57.
Pushed by ppenz into branch 'master'.

Use KMessageWidget for error- and information-messages

See http://agateau.com/2011/04/21/kde-ux-2011/ for more details.
This simplifies the statusbar in Dolphin a lot and allows to
do a proper eliding in case if status-messages are too long: In
this case a tooltip will show the whole status-message (thanks
to Wolfgang Mader for the initial patch!).

There is still missing some finetuning but the general approach
seems to work quite nice.
Related: bug 249638, bug 146533
FIXED-IN: 4.9.0

M  +14   -20   dolphin/src/dolphinmainwindow.cpp
M  +2    -2    dolphin/src/dolphinnewfilemenu.cpp
M  +79   -51   dolphin/src/dolphinviewcontainer.cpp
M  +28   -10   dolphin/src/dolphinviewcontainer.h
M  +93   -152  dolphin/src/statusbar/dolphinstatusbar.cpp
M  +32   -65   dolphin/src/statusbar/dolphinstatusbar.h
M  +9    -9    dolphin/src/statusbar/statusbarspaceinfo.cpp
M  +4    -2    dolphin/src/statusbar/statusbarspaceinfo.h

http://commits.kde.org/kde-baseapps/213450d39704fc0154da5f0e45e4198af8239842
Comment 4 H.H. 2012-04-13 07:44:37 UTC
Thanks, sounds very good, I am looking forward to try this.