Bug 245503 - "Show in original size" does not respect monitor
Summary: "Show in original size" does not respect monitor
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-comic (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Koenig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 07:00 UTC by Rolf Eike Beer
Modified: 2011-07-28 14:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.7.1
Sentry Crash Report:


Attachments
use a parent (1.32 KB, patch)
2010-07-23 16:37 UTC, Matthias Fuchs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer 2010-07-23 07:00:46 UTC
Version:           unspecified (using Devel) 
OS:                Linux

I have two monitors, the comic applet is on the right one. Whenever I open a comic in it's original size it will show up on the left monitor, far away from the applet.

Reproducible: Always
Comment 1 Matthias Fuchs 2010-07-23 16:35:42 UTC
SVN commit 1153571 by mfuchs:

Sets a parent to the FullViewWidget, might solve the issue of displaying it on the wrong screen.
CCBUG:245503

 M  +1 -1      comic.cpp  
 M  +2 -2      fullviewwidget.cpp  
 M  +1 -1      fullviewwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1153571
Comment 2 Matthias Fuchs 2010-07-23 16:37:40 UTC
Created attachment 49438 [details]
use a parent

Can you please try out rev 1153571 or alternatively the attached patch if that fixes the issue for you?
Comment 3 Matthias Fuchs 2010-08-10 18:45:43 UTC
SVN commit 1161709 by mfuchs:

Fullview of comic applet should be displayed on the correct screen now if the user have multiple displays.
BUG:245503

 M  +3 -3      comic.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1161709
Comment 4 Matthias Fuchs 2010-08-10 18:50:37 UTC
SVN commit 1161712 by mfuchs:

Fowardport r1161709
Fullview of comic applet should be displayed on the correct screen now if the user have multiple displays.
CCBUG:245503

 M  +3 -3      comic.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1161712
Comment 5 Matthias Fuchs 2010-08-10 18:51:08 UTC
This should be fixed (thx to aseigo) in 4.5.1, if the problem still exists then please reopen this report.
Comment 6 Rolf Eike Beer 2010-10-09 14:12:44 UTC
Still doesn't work in 4.5.1 and 4.5.2
Comment 7 Matthias Fuchs 2011-07-27 16:57:02 UTC
Git commit 77a309e60b4efef3fc58be395cc5552d4b490d91 by Matthias Fuchs.
Committed on 27/07/2011 at 18:55.
Pushed by mfuchs into branch '4.7'.

Comic FullViewWidget is displayed on the correct monitor.

BUG: 245503
FIXED-IN:4.7.1

M  +1    -1    applets/comic/comic.cpp
M  +14   -4    applets/comic/fullviewwidget.cpp

http://commits.kde.org/kdeplasma-addons/77a309e60b4efef3fc58be395cc5552d4b490d91
Comment 8 Matthias Fuchs 2011-07-27 16:58:44 UTC
Git commit 350ab75d5fab21ac22699e5b5f84f134caa3875f by Matthias Fuchs.
Committed on 27/07/2011 at 18:55.
Pushed by mfuchs into branch 'master'.

Fowardport 77a309e60b4efef3fc58be395cc5552d4b490d91
Comic FullViewWidget is displayed on the correct monitor.

CCBUG: 245503
(cherry picked from commit 77a309e60b4efef3fc58be395cc5552d4b490d91)

M  +1    -1    applets/comic/comic.cpp
M  +14   -4    applets/comic/fullviewwidget.cpp

http://commits.kde.org/kdeplasma-addons/350ab75d5fab21ac22699e5b5f84f134caa3875f
Comment 9 Matthias Fuchs 2011-07-28 14:51:48 UTC
Git commit 8b281ee1586445c8251abf4f8695f99cc065df7c by Matthias Fuchs.
Committed on 28/07/2011 at 16:22.
Pushed by mfuchs into branch '4.7'.

Improves 77a309e60b4efef3fc58be395cc5552d4b490d91

The previous commit only fixed fullscreen for comic displayed in plasmoidviewer as I realised later.
Now it works also at least for the comic applet on plasma-desktop and in the panel.

CCBUG:245503

M  +3    -9    applets/comic/comic.cpp
M  +1    -1    applets/comic/fullviewwidget.h
M  +5    -4    applets/comic/fullviewwidget.cpp

http://commits.kde.org/kdeplasma-addons/8b281ee1586445c8251abf4f8695f99cc065df7c
Comment 10 Matthias Fuchs 2011-07-28 14:54:07 UTC
Git commit cd9b2d6f0114ca190b403474269f049f76a68eca by Matthias Fuchs.
Committed on 28/07/2011 at 16:22.
Pushed by mfuchs into branch 'master'.

The previous commit only fixed fullscreen for comic displayed in plasmoidviewer as I realised later.
Now it works also at least for the comic applet on plasma-desktop and in the panel.

CCBUG:245503
(cherry picked from commit 8b281ee1586445c8251abf4f8695f99cc065df7c)

M  +3    -9    applets/comic/comic.cpp
M  +1    -1    applets/comic/fullviewwidget.h
M  +5    -4    applets/comic/fullviewwidget.cpp

http://commits.kde.org/kdeplasma-addons/cd9b2d6f0114ca190b403474269f049f76a68eca