Bug 238269 - When selecting text with "Highlighter" review tool, dragging past view area bottom should scroll
Summary: When selecting text with "Highlighter" review tool, dragging past view area b...
Status: RESOLVED DUPLICATE of bug 165744
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.9.2
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 08:04 UTC by Jesse Taylor
Modified: 2010-05-22 19:57 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Taylor 2010-05-20 08:04:32 UTC
Version:           0.9.2 (using KDE 4.3.2)
OS:                Linux
Installed from:    Ubuntu Packages

Currently when selecting text with the "Yellow Highlighter" from the Reviews toolbar, if I am selecting a large body of text and reach the bottom of the screen, Okular does not scroll the page and allow me to continue highlighting further down. It just stops, which means that I then have to delete the annotation, zoom out, and redo. Sometimes, if I want to select a very large portion of the page, I have to zoom out so much that I can't read the text anymore. What I would like, is for Okular to scroll down the page when I drag the highlighter tool past the bottom of the viewing area.

Second, when I reach the bottom of a page, and wish to continue highlighting on the following page, Okular does not allow me to continue dragging the highlighter past the end of a page and continue onto the next one -- I instead have to do two separate annotations, one per page. 

The second issue (not allowing to continue highlighting from one page to the next), seems like there might be a technical difficulty in implementing it, due to the way that the docdata XML format for Okular stores annotations with a <pageList>, where each <page> contains <annotation>'s, rather than having a list of <annotation>'s containing <pages> elements. It seems like this would require some modification of the way that Okular stores annotations, which might not be worth the effort considering the benefits.

However, the first issue (scrolling when dragging past bottom of screen) seems like it should be relatively simple to implement, and doesn't seem like it would require any heavy overhauls of anything. Any reasons why this would not be fixable?

Thanks,
Jesse Taylor
Comment 1 Albert Astals Cid 2010-05-20 09:48:21 UTC
<quote>
Any reasons why this would not be fixable?
</quote>
Time.

As always patches are welcome.
Comment 2 Pino Toscano 2010-05-22 19:57:43 UTC
(In reply to comment #0)
> Currently when selecting text with the "Yellow Highlighter" from the Reviews
> toolbar, if I am selecting a large body of text and reach the bottom of the
> screen, Okular does not scroll the page and allow me to continue highlighting
> further down.

This is bug #165744.

> The second issue (not allowing to continue highlighting from one page to the
> next), seems like there might be a technical difficulty in implementing it, due
> to the way that the docdata XML format for Okular stores annotations [...]

No, issue is unrelated to that: okular could let you scroll and continue the selection to another page, but this would always result in the highlight split in the pages it selected; this is due to the fact that annotations, as designed in the PDF standard, are specific to a page, so they cannot span more than one.

*** This bug has been marked as a duplicate of bug 165744 ***