Version: (using KDE 4.4.2) Installed from: Ubuntu Packages When you run KTimeTracker the icon behaves as if there are two instances of KTimeTracker (one without an icon) which makes the tray contain an empty entry. Also, the option in KTimeTracker to remove the tray icon has no effect at all.
Created attachment 43309 [details] Screenshot of the bug
Created attachment 43535 [details] Screenshot with wrong behaviour and additional misplaced icons on the clock
Created attachment 43536 [details] Screenshot of two row system tray
I can approve this bug. I added two additional screenshots which show the wrong behaviour. The screenshots are from two different computers both running KDE 4.4.3. I first saw this with KDE 4.4.0, it worked well with 4.4.x. In the first screenshot (attachment (id=43535)) there are also some of the system tray icons misplaced which appear on the clock. This might be related to this bug.
Thank you for the report. I am on a trip and cannot try to reproduce. Will be back in june. Any patch is appreciated.
Created attachment 51728 [details] systemtray and ktimetracker
Comment on attachment 51728 [details] systemtray and ktimetracker I confirm this bug on FreeBSD 8.1 & KDE 4.4.5
I confirm on Gentoo amd64 & KDE-4.5.1
*** This bug has been confirmed by popular vote. ***
Created attachment 56551 [details] Screenshot of the system tray This attachment shows the icons are not rendered at the correct places.
Just want to add that this bug (shown in the attached screenshot) was observed on Arch Linux i686 using KDE SC 4.6.0. Notice Skype's system tray icon is rendered out of place, and there's a gap in the extender as well. The gap appeared after quiting kmix, restarting kmix doesn't remove the gap.
*** Bug 271216 has been marked as a duplicate of this bug. ***
KDE SC 4.6.2 on Kubuntu 11.04, confirming this bug. There are two instances of ktimetracker in the tray.
I have the same setup as Comment #14: KDE 4.6.2 (Kubuntu 11.04). I can also confirm this bug. It is unchanged from KDE 4.4.2 (Mint 9).
Hey all that are affected Won't this bug be fixed? Will be nice to have correct systray icons ;) thanks thomi
Still in KTimeTracker 4.6.90
Created attachment 61815 [details] In a vertical layout is clear that there are two entries
Preliminary patch, needs to be tested, cleaned and refined: diff --git a/ktimetracker/ktimetrackerpart.cpp b/ktimetracker/ktimetrackerpart.cpp index f466370..45c856d 100644 --- a/ktimetracker/ktimetrackerpart.cpp +++ b/ktimetracker/ktimetrackerpart.cpp @@ -97,8 +97,6 @@ bool ktimetrackerpart::openFile(QString icsfile) { mMainWidget->openFile(icsfile); emit setWindowCaption(icsfile); - if ( KTimeTrackerSettings::trayIcon() ) mTray = new TrayIcon( this ); - else mTray = new TrayIcon( ); // connections connect( mMainWidget, SIGNAL(totalTimesChanged(long,long)), @@ -107,11 +105,6 @@ bool ktimetrackerpart::openFile(QString icsfile) this, SLOT(setStatusBar(QString)) ); connect( mMainWidget, SIGNAL(setCaption(QString)), this, SIGNAL(setWindowCaption(QString)) ); - connect( mTray, SIGNAL(quitSelected()), SLOT(quit()) ); - connect( mMainWidget, SIGNAL(timersActive()), mTray, SLOT(startClock()) ); - connect( mMainWidget, SIGNAL(timersInactive()), mTray, SLOT(stopClock()) ); - connect( mMainWidget, SIGNAL(tasksChanged(QList<Task*>)), - mTray, SLOT(updateToolTip(QList<Task*>))); return true; } diff --git a/ktimetracker/ktimetrackerpart.h b/ktimetracker/ktimetrackerpart.h index 1b308df..dff0654 100644 --- a/ktimetracker/ktimetrackerpart.h +++ b/ktimetracker/ktimetrackerpart.h @@ -44,7 +44,6 @@ class ktimetrackerpart : public KParts::ReadWritePart private: void makeMenus(); - TrayIcon *mTray; TimetrackerWidget *mMainWidget;
No more screenshots, please! It is clear that this is a bug and should be fixed. Please provide patches instead of screenshots :)
Fixed. The problem was that we wanted (a) a standalone application ktimetracker (b) a kontact plugin for ktimetracker So we created a kpart (that created a trayicon) and the mainwindow (in the standalone application) continued to create a trayicon -> two trayicons were created for the standalone application. Also, quitting via the menu item "quit" works now.
Never closed a 217 votes bug on ktimetracker before. People, please test :)
Here is the commit: http://quickgit.kde.org/?p=kdepim.git&a=commit&h=2733d0dc422fff8691a828579db372570741bb21
Git commit ff4ab352188edddd55baa8e2f7dfa26d1dc530ed by Thorsten Staerk. Committed on 09/10/2011 at 17:31. Pushed by tstaerk into branch 'KDE/4.7'. Only display icon in system tray once. Backport from master. BUGS:236566 M +0 -7 ktimetracker/ktimetrackerpart.cpp http://commits.kde.org/kdepim/ff4ab352188edddd55baa8e2f7dfa26d1dc530ed